From: Miklos Szeredi Subject: Re: [patch 18/21] vfs: seq_file: add helpers for data filling Date: Mon, 21 Sep 2009 14:43:40 +0200 Message-ID: <1253537020.27376.68.camel@tucsk> References: <200909182006.n8IK604x019735@imap1.linux-foundation.org> <20090921100301.GI5858@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, Valdis.Kletnieks@vt.edu, agruen@suse.de, hch@lst.de, hugh.dickins@tiscali.co.uk, matthew@wil.cx To: Al Viro Return-path: Received: from cantor2.suse.de ([195.135.220.15]:47482 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755840AbZIUMn5 (ORCPT ); Mon, 21 Sep 2009 08:43:57 -0400 In-Reply-To: <20090921100301.GI5858@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2009-09-21 at 11:03 +0100, Al Viro wrote: > On Fri, Sep 18, 2009 at 01:06:00PM -0700, akpm@linux-foundation.org wrote: > > From: Miklos Szeredi > > > > Add two helpers that allow access to the seq_file's own buffer, but > > hides the internal details of seq_files. > > > > This allows easier implementation of special purpose filling > > functions. It also cleans up some existing functions which duplicated > > the seq_file logic. > > Nice, but I suspect that exporting those two would be the right thing. > That, or inlining them - we are not actually hiding anything here, seeing > that struct seq_file is declared right there in the seq_file.h. > > I'm certainly fine with these helpers and associated cleanup. Unless > somebody has realistic plans of actually hiding the seq_file implementation[1], > I'd simply inline those two in seq_file.h. Miklos? Updated patches coming up. Thanks, Miklos