Return-Path: Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.123] helo=mx.sourceforge.net) by 3yr0jf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MsFvV-0000LG-Fl for ltp-list@lists.sourceforge.net; Mon, 28 Sep 2009 13:06:01 +0000 Received: from e4.ny.us.ibm.com ([32.97.182.144]) by 3b2kzd1.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1MsFvQ-0001Ic-LW for ltp-list@lists.sourceforge.net; Mon, 28 Sep 2009 13:06:01 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n8SCwZQF026620 for ; Mon, 28 Sep 2009 08:58:35 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8SD5nci110890 for ; Mon, 28 Sep 2009 09:05:49 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8SD5kcw004519 for ; Mon, 28 Sep 2009 09:05:47 -0400 From: Subrata Modak In-Reply-To: <4AC05D99.9010907@cn.fujitsu.com> References: <4AC05D99.9010907@cn.fujitsu.com> Date: Mon, 28 Sep 2009 18:35:30 +0530 Message-Id: <1254143132.5035.4.camel@subratamodak.linux.ibm.com> Mime-Version: 1.0 Subject: Re: [LTP] [PATCH] memcg : fix various test failures Reply-To: subrata@linux.vnet.ibm.com List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: liubo Cc: ltp-list@lists.sourceforge.net On Mon, 2009-09-28 at 14:54 +0800, liubo wrote: > In memcg testcases, > > 1. use /dev/memcg consistently > > 2. for testcase_25, since 2.6.31, writing -1 to > memory.limit_in_bytes will reset to unlimit. > > 3. for testcase_35, writing to memory.force_empty for > non-empty cgroup should return failure. > > Signed-off-by: Liu Bo Thanks. Regards-- Subrata > > --- > diff --git a/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh b/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > index e48c8dd..e22954f 100755 > --- a/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > +++ b/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > @@ -398,8 +398,12 @@ testcase_24() > testcase_25() > { > echo -1 > memory.limit_in_bytes 2> /dev/null > -# result $(( !($? != 0) )) "return value is $?" //lizf > - result $(( !($? == 0) )) "return value is $?" > + tst_kvercmp 2 6 31 > + if [ $? -eq 0 ]; then > + result $(( !($? != 0) )) "return value is $?" > + else > + result $(( !($? == 0) )) "return value is $?" > + fi > } > > testcase_26() > @@ -488,8 +492,8 @@ testcase_35() > { > # writing to non-empty top mem cgroup's force_empty > # should return failure > - echo 1 > /memcg/memory.force_empty 2> /dev/null > - result $(( $? )) "return value is $?" > + echo 1 > /dev/memcg/memory.force_empty 2> /dev/null > + result $(( !$? )) "return value is $?" > } > > # Case 36 - 38: Test that group and subgroup have no relationship > diff --git a/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh b/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh > index 1e17525..86b8cb9 100755 > --- a/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh > +++ b/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh > @@ -68,11 +68,11 @@ run_stress() > > for ((i = 0; i < $1; i++)) > { > - mkdir /memcg/$i 2> /dev/null > + mkdir /dev/memcg/$i 2> /dev/null > ./memcg_process_stress $2 $3 & > pid[$i]=$! > > - echo ${pid[$i]} > /memcg/$i/tasks > + echo ${pid[$i]} > /dev/memcg/$i/tasks > } > > for ((i = 0; i < $1; i++)) > @@ -87,7 +87,7 @@ run_stress() > /bin/kill -s SIGINT ${pid[$i]} 2> /dev/null > wait ${pid[$i]} > > - rmdir /memcg/$i 2> /dev/null > + rmdir /dev/memcg/$i 2> /dev/null > } > > cleanup; > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list