Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz83C-0004VJ-NZ for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 08:06:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz83B-0004UD-4p for grub-devel@gnu.org; Sat, 17 Oct 2009 08:06:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz836-0004Q1-IS for grub-devel@gnu.org; Sat, 17 Oct 2009 08:06:20 -0400 Received: from [199.232.76.173] (port=57497 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz835-0004Pn-2E for grub-devel@gnu.org; Sat, 17 Oct 2009 08:06:15 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:64245) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mz834-0002uJ-DU for grub-devel@gnu.org; Sat, 17 Oct 2009 08:06:14 -0400 Received: from [85.180.43.35] (e180043035.adsl.alicedsl.de [85.180.43.35]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0LeS5t-1MSmMK0W9F-00qih4; Sat, 17 Oct 2009 14:06:13 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20091017120013.GA4040@thorin> References: <4AD87D15.7060408@gmail.com> <20091016160156.GA4986@nubol.oskuro.net> <20091016183805.GE7037@thorin> <4AD8D305.5000806@gmail.com> <20091016205258.GA8496@thorin> <4AD8E0CF.9080509@gmail.com> <20091016215343.GA9378@thorin> <4AD8F11D.1030007@gmail.com> <20091017112545.GA3556@thorin> <4AD9ADE9.3020004@gmail.com> <20091017120013.GA4040@thorin> Content-Type: text/plain; charset="UTF-8" Date: Sat, 17 Oct 2009 14:06:12 +0200 Message-Id: <1255781172.3373.17.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX18DghWZjSeXDmMZrVmfv8ZE2LxtJTJzCVbsk10 D3JTCA+kZsUYErqK9R+uRqRHLIRj02VnD/JQ4I28uJlMeOt/MK Fx9ihLu0MmgDkWtuqymXvsBGbE4UxV4 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Refuse to install on XFS destroying its superblock X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 12:06:21 -0000 Am Samstag, den 17.10.2009, 14:00 +0200 schrieb Robert Millan: > On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Robert Millan wrote: > > > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > > >> 2009-10-16 Vladimir Serbinenko > > >> > > >> + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. > > >> + (options): New option --destroy-xfs. > > >> + (main): Handle --destroy-xfs. > > >> > > > > > > I gave this some more thought, and I think this could be less ad-hoc. We're > > > treating XFS as if it were a "weird", unique thing just because it isn't biased > > > towards DOS-style boot like most filesystems are. > > > > > > Instead, I've done something more generic, using our standard filesystem > > > probing engine which should be more reliable than a single memcmp. > > > > > > > > The danger is that fs_probe may reject filesystem as valid just because > > it's newer than expected. > > What do you mean with "reject filesystem as valid"? For example with the extN filesystems we reject them as valid if they use INCOMPAT flags we don't support. For example external ext3/4 journal devices, which caused a reboot or segfault or something like that, before we commited Javier's patch for it. In that case it doestn't matter because the first sector is still unused but for other filesystems this could maybe be a problem. -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer