Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz8kN-0001DW-ER for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 08:51:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz8kI-0001Ac-Pk for grub-devel@gnu.org; Sat, 17 Oct 2009 08:50:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz8kC-00017s-Em for grub-devel@gnu.org; Sat, 17 Oct 2009 08:50:52 -0400 Received: from [199.232.76.173] (port=52357 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz8k9-00017V-Ri for grub-devel@gnu.org; Sat, 17 Oct 2009 08:50:46 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:61450) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mz8k8-0001Pi-Eb for grub-devel@gnu.org; Sat, 17 Oct 2009 08:50:44 -0400 Received: from [85.180.43.35] (e180043035.adsl.alicedsl.de [85.180.43.35]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MbtcA-1MjG3I2VOA-00JGYa; Sat, 17 Oct 2009 14:50:42 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <4AD9B795.6000201@parallels.com> References: <4AD9B795.6000201@parallels.com> Content-Type: text/plain; charset="UTF-8" Date: Sat, 17 Oct 2009 14:50:41 +0200 Message-Id: <1255783841.3373.20.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/O7NHU8SBFPR0FMiQcgMh5c2sFINcvv7e6N9Q IUv82sa047g421S8p+uagL4ucIt7iuSuNjRNpjBO7zGnE7VCge RtEJGbVPB2DglaSJV09Zg== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [patch] incorrect root device while /dev/ on tmpfs X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 12:50:56 -0000 Am Samstag, den 17.10.2009, 16:24 +0400 schrieb Vasily Averin: > While /dev mounted as tmpfs it does not contain /dev/disk/by-uuid > directory, > 10_linux script did not check it properly and do not set root device > via UUID. > Therefore following kernel boot can fail (incorrect root device) if > device names > was changed. > > Attached path fixes this issue. Please review and commit it On Debian at least /dev is always a udev managed tmpfs, except in the case you boot from a livecd and chroot of course. I fail to see why the check if /dev/disk/by-uuid is a directory does fix anything. If /dev/disk/by-uuid/abc123 doestn't exit, then this implies that /dev/disk/by-uuid is not a directory. Or is this some bug in the test command we need to workaround? -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer