Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2zKf-00063I-G0 for qemu-devel@nongnu.org; Tue, 27 Oct 2009 23:36:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2zKa-00062f-VO for qemu-devel@nongnu.org; Tue, 27 Oct 2009 23:36:21 -0400 Received: from [199.232.76.173] (port=59033 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2zKa-00062b-RL for qemu-devel@nongnu.org; Tue, 27 Oct 2009 23:36:16 -0400 Received: from ey-out-1920.google.com ([74.125.78.147]:49850) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2zKa-00008R-BC for qemu-devel@nongnu.org; Tue, 27 Oct 2009 23:36:16 -0400 Received: by ey-out-1920.google.com with SMTP id 3so382460eyh.14 for ; Tue, 27 Oct 2009 20:36:14 -0700 (PDT) Content-Type: text/plain; charset=utf8 From: Scott Tsai In-reply-to: <1256667399-3149-1-git-send-email-markmc@redhat.com> References: <1256667399-3149-1-git-send-email-markmc@redhat.com> Date: Wed, 28 Oct 2009 11:36:11 +0800 Message-Id: <1256700810-sup-7579@xpc65.scottt> Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap queue drain List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Sven Rudolph , qemu-devel > Scott, Sven, if you could test the tap-drain-queue branch from > my tree, that would be great: > http://repo.or.cz/w/qemu/markmc.git > > Thanks, > Mark. Mark, I've tested http://repo.or.cz/w/qemu/markmc.git and it indeed works for my test case (NFS through emulated smc91c111 NIC on arm-integragorcp) How about adding a comment in tap_send() about when qemu_send_packet_async() would return 0 and -1? I'd also recommend checking for the case of qemu_send_packet_async() returning -1 and dropping a packet and have a debug message guarded by #ifdef DEBUG_TAP in case the qemu_can_send_packet() check is ever removed in future modifications of the code. Also, would it be possible to get the stable-0.11 version of the patch into the soon to be released Fedora 12? I've written some embedded Linux tutorials for Taiwanese consumer electronics developers that recommends using qemu on Fedora. Being able to rely on NFS always working in Fedora's qmeu packet would really help :)