From: Ian Campbell Subject: Re: [PATCH 3/3] xen: rename pciback module to xen-pciback. Date: Thu, 3 Dec 2009 22:14:28 +0000 Message-ID: <1259878468.31045.139.camel@localhost.localdomain> References: <1259877380-32275-1-git-send-email-ian.campbell@citrix.com> <1259877380-32275-4-git-send-email-ian.campbell@citrix.com> <20091203220237.GA21885@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091203220237.GA21885@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: Fitzhardinge , "xen-devel@lists.xensource.com" , Jeremy List-Id: xen-devel@lists.xenproject.org On Thu, 2009-12-03 at 22:02 +0000, Konrad Rzeszutek Wilk wrote: > On Thu, Dec 03, 2009 at 09:56:20PM +0000, ian.campbell@citrix.com wrote: > > pciback is rather generic for a modular distro style kernel. > > Do you have a patch for Xen python stack to check ownership of > PCI devices to also be 'xen-pciback'? Ah, it never even occurred to me that such a thing would be necessary. I think (but I should check) that the sysfs name will remain pciback since it comes from the .name in struct xenbus_driver. I'm not sure if it is confusing or not to have the module name be different to the driver name nor how common it is. Ian. > > > > > Signed-off-by: Ian Campbell > > Cc: Jeremy Fitzhardinge > > Cc: Konrad Rzeszutek Wilk > > Acked-by: Konrad Rzeszutek Wilk > > > --- > > drivers/xen/pciback/Makefile | 24 ++++++++++++------------ > > 1 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/xen/pciback/Makefile b/drivers/xen/pciback/Makefile > > index 106dae7..38bc123 100644 > > --- a/drivers/xen/pciback/Makefile > > +++ b/drivers/xen/pciback/Makefile > > @@ -1,16 +1,16 @@ > > -obj-$(CONFIG_XEN_PCIDEV_BACKEND) += pciback.o > > +obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback.o > > > > -pciback-y := pci_stub.o pciback_ops.o xenbus.o > > -pciback-y += conf_space.o conf_space_header.o \ > > - conf_space_capability.o \ > > - conf_space_capability_vpd.o \ > > - conf_space_capability_pm.o \ > > - conf_space_quirks.o > > -pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o > > -pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o > > +xen-pciback-y := pci_stub.o pciback_ops.o xenbus.o > > +xen-pciback-y += conf_space.o conf_space_header.o \ > > + conf_space_capability.o \ > > + conf_space_capability_vpd.o \ > > + conf_space_capability_pm.o \ > > + conf_space_quirks.o > > +xen-pciback-$(CONFIG_PCI_MSI) += conf_space_capability_msi.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_VPCI) += vpci.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_SLOT) += slot.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_PASS) += passthrough.o > > +xen-pciback-$(CONFIG_XEN_PCIDEV_BACKEND_CONTROLLER) += controller.o > > > > ifeq ($(CONFIG_XEN_PCIDEV_BE_DEBUG),y) > > EXTRA_CFLAGS += -DDEBUG > > -- > > 1.6.5.3 > >