From: Peter Tyser Date: Fri, 04 Dec 2009 18:18:41 -0600 Subject: [U-Boot] [PATCH 1/3] tools/mkimage: Assume FDT image type for FIT images In-Reply-To: <20091205001332.65F6C3F6E3@gemini.denx.de> References: <1259102530-32071-1-git-send-email-ptyser@xes-inc.com> <20091205001332.65F6C3F6E3@gemini.denx.de> Message-ID: <1259972321.23828.13300.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, 2009-12-05 at 01:13 +0100, Wolfgang Denk wrote: > Dear Peter Tyser, > > In message <1259102530-32071-1-git-send-email-ptyser@xes-inc.com> you wrote: > > When building a Flattened Image Tree (FIT) the image type needs to be > > "flat_dt". Commit 89a4d6b12fd6394898b8a454cbabeaf1cd59bae5 introduced a > > regression which caused the user to need to specify the "-T flat_dt" > > parameter on the command line when building a FIT image. The "-T > > flat_dt" parameter should not be needed and is at odds with the current > > FIT image documentation. > > > > Signed-off-by: Peter Tyser > > --- > > Ideally this patch would make it into the upcoming release as its a > > regression. I don't really care when 2/3 and 3/3 are applied, they > > aren't really bug fixes. > > Not really, but a nice cleanup is as good as a fix :-) > > > tools/mkimage.c | 6 ++++++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > Applied, thanks. > > Best regards, > > Wolfgang Denk > Hi Wolfgang, Thanks for applying patches 2 and 3. Stefano Babic noticed that this change was already submitted by Remy and was merged in 6a590c5f5fd12cdd27f3153522acfac3854590e7, so 1/3 shouldn't be necessary. My fix was nearly identical to Remy's I'm a bit surprised mine would apply cleanly... Thanks! Peter