From: Ian Campbell Subject: Re: [PATCH][v2] Hybrid extension support in Xen Date: Tue, 2 Feb 2010 18:03:55 +0000 Message-ID: <1265133835.3247.5.camel@localhost.localdomain> References: <201002021616.19189.sheng@linux.intel.com> <201002022207.10764.sheng@linux.intel.com> <1265127350.24394.572.camel@zakaz.uk.xensource.com> <201002030031.26179.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201002030031.26179.sheng@linux.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Sheng Yang Cc: Keir, "xen-devel@lists.xensource.com" , Fraser List-Id: xen-devel@lists.xenproject.org On Tue, 2010-02-02 at 16:31 +0000, Sheng Yang wrote: > > > I just meant that you should enable evtchn mode at the point at > which > > the guest tries to use event channels and not in some specific > "enable > > hybrid mode call", similarly for PV-timer mode etc. > > > > Of course that presupposes that event channels and APIC etc are > mutually > > exclusive, which I don't think is a given. > > I would give it try. Seems I need to bind tsc offset clean in event > channel binding hypercall(if I didn't introduce another hypercall), > sounds a little messy. I guess to clarify what I really meant was in the code which enables the PV timer for a domain, rather than specifically in the event channel hypercall which implements the binding to the timer evtchn. I'm not sure if enabling the timer is a separate hypercall or is just a side effect of binding to the evtchn. Ian.