From: "Matthew W. S. Bell" Subject: Re: [PATCH] libdrm compile warnings fixes Date: Sat, 06 Feb 2010 04:18:58 +0000 Message-ID: <1265429938.3710.64.camel@ibis.bells> References: <1265311428.3710.26.camel@ibis.bells> <59ad55d31002041648p70843179g1f30434201f880bf@mail.gmail.com> Reply-To: matthew@bells23.org.uk, dri-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3735426995338270295==" Return-path: In-Reply-To: <59ad55d31002041648p70843179g1f30434201f880bf@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: dri-devel@lists.sourceforge.net List-Id: dri-devel@lists.freedesktop.org --===============3735426995338270295== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-+bloULqJxMWIOj1O4QvB" --=-+bloULqJxMWIOj1O4QvB Content-Type: multipart/mixed; boundary="=-MhlfxaOLvJK7QAJezO07" --=-MhlfxaOLvJK7QAJezO07 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2010-02-04 at 19:48 -0500, Kristian H=C3=B8gsberg wrote: > On Thu, Feb 4, 2010 at 2:23 PM, Matthew W. S. Bell > > Additionally, the function libdrm/xf86drmSL.c:drmSLLookupNeighbors() > > appears to be completely broken as it computes on the variable update > > which is unconditionally undefined. >=20 > Yeah, nothing really uses the skip list and I'd like to drop it and > the hash table. I guess it's not a big deal though... Well, it's a small function that's part of a public API, it should either do something other than return undefined results or be removed. As such, here is a patch removing it. Also attached is a patch for another warning fix. Matthew W.S. Bell --=-MhlfxaOLvJK7QAJezO07 Content-Disposition: attachment; filename="0001-Cast-type-for-printf-to-silence-warning.patch" Content-Type: text/x-patch; name="0001-Cast-type-for-printf-to-silence-warning.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzMjAzYmNiYWUxNDYxMWZhNGMzZGY4YjFjOWZlODFhNzM4OTkxODE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTWF0dGhldyBXLiBTLiBCZWxsIDxtYXR0aGV3QGJlbGxzMjMu b3JnLnVrPg0KRGF0ZTogU2F0LCA2IEZlYiAyMDEwIDA0OjEwOjMxICswMDAwDQpTdWJqZWN0OiBb UEFUQ0ggMS8yXSBDYXN0IHR5cGUgZm9yIHByaW50ZiB0byBzaWxlbmNlIHdhcm5pbmcuDQoNCi0t LQ0KIHRlc3RzL2RybXN0YXQuYyB8ICAgIDIgKy0NCiAxIGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL3Rlc3RzL2RybXN0YXQuYyBi L3Rlc3RzL2RybXN0YXQuYw0KaW5kZXggMzQ1YjhkMi4uZWE5ZDEyZiAxMDA2NDQNCi0tLSBhL3Rl c3RzL2RybXN0YXQuYw0KKysrIGIvdGVzdHMvZHJtc3RhdC5jDQpAQCAtMjg4LDcgKzI4OCw3IEBA IGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikNCiAJCWRybUVycm9yKHIsIGFyZ3ZbMF0p Ow0KIAkJcmV0dXJuIDE7DQogCSAgICB9DQotCSAgICBwcmludGYoIjB4JTA0bHggYnl0ZSBzaG0g YWRkZWQgYXQgMHglMDhseFxuIiwgc2l6ZSwgaGFuZGxlKTsNCisJICAgIHByaW50ZigiMHglMDRs eCBieXRlIHNobSBhZGRlZCBhdCAweCUwOGx4XG4iLCBzaXplLCAodW5zaWduZWQgbG9uZyloYW5k bGUpOw0KIAkgICAgc3ByaW50ZihidWYsICJjYXQgL3Byb2MvZHJpLzAvdm0iKTsNCiAJICAgIHN5 c3RlbShidWYpOw0KIAkgICAgYnJlYWs7DQotLSANCjEuNi41DQoNCg== --=-MhlfxaOLvJK7QAJezO07 Content-Disposition: attachment; filename*0=0002-Eliminate-drmSLLookupNeighbors-as-it-appears-to-want.pat; filename*1=ch Content-Type: text/x-patch; name="0002-Eliminate-drmSLLookupNeighbors-as-it-appears-to-want.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAwNGM3NDQzY2M3ZjE2NTc4YzAwZDQ1NjE3YzkxYjUxYzI2YmRlYzE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogTWF0dGhldyBXLiBTLiBCZWxsIDxtYXR0aGV3QGJlbGxzMjMu b3JnLnVrPg0KRGF0ZTogU2F0LCA2IEZlYiAyMDEwIDA0OjExOjAyICswMDAwDQpTdWJqZWN0OiBb UEFUQ0ggMi8yXSBFbGltaW5hdGUgZHJtU0xMb29rdXBOZWlnaGJvcnMgYXMgaXQgYXBwZWFycyB0 byB3YW50IGFuDQogU0xMb2NhdGVOZWlnaGJvcnMgZnVuY3Rpb24gdGhhdCBuZXZlciBleGlzdGVk Lg0KDQotLS0NCiB4Zjg2ZHJtLmggICB8ICAgIDMgLS0tDQogeGY4NmRybVNMLmMgfCAgIDUxIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KIDIgZmls ZXMgY2hhbmdlZCwgMCBpbnNlcnRpb25zKCspLCA1NCBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdp dCBhL3hmODZkcm0uaCBiL3hmODZkcm0uaA0KaW5kZXggOWI4OWY1Ni4uOWNlYzA2NiAxMDA2NDQN Ci0tLSBhL3hmODZkcm0uaA0KKysrIGIveGY4NmRybS5oDQpAQCAtNjgyLDkgKzY4Miw2IEBAIGV4 dGVybiBpbnQgIGRybVNMRGVsZXRlKHZvaWQgKmwsIHVuc2lnbmVkIGxvbmcga2V5KTsNCiBleHRl cm4gaW50ICBkcm1TTE5leHQodm9pZCAqbCwgdW5zaWduZWQgbG9uZyAqa2V5LCB2b2lkICoqdmFs dWUpOw0KIGV4dGVybiBpbnQgIGRybVNMRmlyc3Qodm9pZCAqbCwgdW5zaWduZWQgbG9uZyAqa2V5 LCB2b2lkICoqdmFsdWUpOw0KIGV4dGVybiB2b2lkIGRybVNMRHVtcCh2b2lkICpsKTsNCi1leHRl cm4gaW50ICBkcm1TTExvb2t1cE5laWdoYm9ycyh2b2lkICpsLCB1bnNpZ25lZCBsb25nIGtleSwN Ci0JCQkJIHVuc2lnbmVkIGxvbmcgKnByZXZfa2V5LCB2b2lkICoqcHJldl92YWx1ZSwNCi0JCQkJ IHVuc2lnbmVkIGxvbmcgKm5leHRfa2V5LCB2b2lkICoqbmV4dF92YWx1ZSk7DQogDQogZXh0ZXJu IGludCBkcm1PcGVuT25jZSh2b2lkICp1bnVzZWQsIGNvbnN0IGNoYXIgKkJ1c0lELCBpbnQgKm5l d2x5b3BlbmVkKTsNCiBleHRlcm4gdm9pZCBkcm1DbG9zZU9uY2UoaW50IGZkKTsNCmRpZmYgLS1n aXQgYS94Zjg2ZHJtU0wuYyBiL3hmODZkcm1TTC5jDQppbmRleCBhY2RkYjU0Li5mMzMyOGRlIDEw MDY0NA0KLS0tIGEveGY4NmRybVNMLmMNCisrKyBiL3hmODZkcm1TTC5jDQpAQCAtOTYsOSArOTYs NiBAQCBleHRlcm4gaW50ICBkcm1TTERlbGV0ZSh2b2lkICpsLCB1bnNpZ25lZCBsb25nIGtleSk7 DQogZXh0ZXJuIGludCAgZHJtU0xOZXh0KHZvaWQgKmwsIHVuc2lnbmVkIGxvbmcgKmtleSwgdm9p ZCAqKnZhbHVlKTsNCiBleHRlcm4gaW50ICBkcm1TTEZpcnN0KHZvaWQgKmwsIHVuc2lnbmVkIGxv bmcgKmtleSwgdm9pZCAqKnZhbHVlKTsNCiBleHRlcm4gdm9pZCBkcm1TTER1bXAodm9pZCAqbCk7 DQotZXh0ZXJuIGludCAgZHJtU0xMb29rdXBOZWlnaGJvcnModm9pZCAqbCwgdW5zaWduZWQgbG9u ZyBrZXksDQotCQkJCSB1bnNpZ25lZCBsb25nICpwcmV2X2tleSwgdm9pZCAqKnByZXZfdmFsdWUs DQotCQkJCSB1bnNpZ25lZCBsb25nICpuZXh0X2tleSwgdm9pZCAqKm5leHRfdmFsdWUpOw0KICNl bmRpZg0KIA0KIHN0YXRpYyBTTEVudHJ5UHRyIFNMQ3JlYXRlRW50cnkoaW50IG1heF9sZXZlbCwg dW5zaWduZWQgbG9uZyBrZXksIHZvaWQgKnZhbHVlKQ0KQEAgLTI1OSwzMCArMjU2LDYgQEAgaW50 IGRybVNMTG9va3VwKHZvaWQgKmwsIHVuc2lnbmVkIGxvbmcga2V5LCB2b2lkICoqdmFsdWUpDQog ICAgIHJldHVybiAtMTsNCiB9DQogDQotaW50IGRybVNMTG9va3VwTmVpZ2hib3JzKHZvaWQgKmws IHVuc2lnbmVkIGxvbmcga2V5LA0KLQkJCSB1bnNpZ25lZCBsb25nICpwcmV2X2tleSwgdm9pZCAq KnByZXZfdmFsdWUsDQotCQkJIHVuc2lnbmVkIGxvbmcgKm5leHRfa2V5LCB2b2lkICoqbmV4dF92 YWx1ZSkNCi17DQotICAgIFNraXBMaXN0UHRyICAgbGlzdCA9IChTa2lwTGlzdFB0cilsOw0KLSAg ICBTTEVudHJ5UHRyICAgIHVwZGF0ZVtTTF9NQVhfTEVWRUwgKyAxXTsNCi0gICAgaW50ICAgICAg ICAgICByZXRjb2RlID0gMDsNCi0NCi0gICAgKnByZXZfa2V5ICAgPSAqbmV4dF9rZXkgICA9IGtl eTsNCi0gICAgKnByZXZfdmFsdWUgPSAqbmV4dF92YWx1ZSA9IE5VTEw7DQotCQ0KLSAgICBpZiAo dXBkYXRlWzBdKSB7DQotCSpwcmV2X2tleSAgID0gdXBkYXRlWzBdLT5rZXk7DQotCSpwcmV2X3Zh bHVlID0gdXBkYXRlWzBdLT52YWx1ZTsNCi0JKytyZXRjb2RlOw0KLQlpZiAodXBkYXRlWzBdLT5m b3J3YXJkWzBdKSB7DQotCSAgICAqbmV4dF9rZXkgICA9IHVwZGF0ZVswXS0+Zm9yd2FyZFswXS0+ a2V5Ow0KLQkgICAgKm5leHRfdmFsdWUgPSB1cGRhdGVbMF0tPmZvcndhcmRbMF0tPnZhbHVlOw0K LQkgICAgKytyZXRjb2RlOw0KLQl9DQotICAgIH0NCi0gICAgcmV0dXJuIHJldGNvZGU7DQotfQ0K LQ0KIGludCBkcm1TTE5leHQodm9pZCAqbCwgdW5zaWduZWQgbG9uZyAqa2V5LCB2b2lkICoqdmFs dWUpDQogew0KICAgICBTa2lwTGlzdFB0ciAgIGxpc3QgPSAoU2tpcExpc3RQdHIpbDsNCkBAIC00 MTAsMjEgKzM4Myw2IEBAIHN0YXRpYyBkb3VibGUgZG9fdGltZShpbnQgc2l6ZSwgaW50IGl0ZXIp DQogICAgIHJldHVybiB1c2VjOw0KIH0NCiANCi1zdGF0aWMgdm9pZCBwcmludF9uZWlnaGJvcnMo dm9pZCAqbGlzdCwgdW5zaWduZWQgbG9uZyBrZXkpDQotew0KLSAgICB1bnNpZ25lZCBsb25nIHBy ZXZfa2V5ID0gMDsNCi0gICAgdW5zaWduZWQgbG9uZyBuZXh0X2tleSA9IDA7DQotICAgIHZvaWQg ICAgICAgICAgKnByZXZfdmFsdWU7DQotICAgIHZvaWQgICAgICAgICAgKm5leHRfdmFsdWU7DQot ICAgIGludCAgICAgICAgICAgcmV0dmFsOw0KLQ0KLSAgICByZXR2YWwgPSBkcm1TTExvb2t1cE5l aWdoYm9ycyhsaXN0LCBrZXksDQotCQkJCSAgJnByZXZfa2V5LCAmcHJldl92YWx1ZSwNCi0JCQkJ ICAmbmV4dF9rZXksICZuZXh0X3ZhbHVlKTsNCi0gICAgcHJpbnRmKCJOZWlnaGJvcnMgb2YgJTVs dTogJWQgJTVsdSAlNWx1XG4iLA0KLQkgICBrZXksIHJldHZhbCwgcHJldl9rZXksIG5leHRfa2V5 KTsNCi19DQotDQogaW50IG1haW4odm9pZCkNCiB7DQogICAgIFNraXBMaXN0UHRyICAgIGxpc3Q7 DQpAQCAtNDQyLDE1ICs0MDAsNiBAQCBpbnQgbWFpbih2b2lkKQ0KICAgICBwcmludChsaXN0KTsN CiAgICAgcHJpbnRmKCJcbj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxuXG4iKTsNCiAg ICAgDQotICAgIHByaW50X25laWdoYm9ycyhsaXN0LCAwKTsNCi0gICAgcHJpbnRfbmVpZ2hib3Jz KGxpc3QsIDUwKTsNCi0gICAgcHJpbnRfbmVpZ2hib3JzKGxpc3QsIDUxKTsNCi0gICAgcHJpbnRf bmVpZ2hib3JzKGxpc3QsIDEyMyk7DQotICAgIHByaW50X25laWdoYm9ycyhsaXN0LCAyMDApOw0K LSAgICBwcmludF9uZWlnaGJvcnMobGlzdCwgMjEzKTsNCi0gICAgcHJpbnRfbmVpZ2hib3JzKGxp c3QsIDI1Nik7DQotICAgIHByaW50ZigiXG49PT09PT09PT09PT09PT09PT09PT09PT09PT09PT1c blxuIik7ICAgIA0KLSAgICANCiAgICAgZHJtU0xEZWxldGUobGlzdCwgNTApOw0KICAgICBwcmlu dChsaXN0KTsNCiAgICAgcHJpbnRmKCJcbj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxu XG4iKTsNCi0tIA0KMS42LjUNCg0K --=-MhlfxaOLvJK7QAJezO07-- --=-+bloULqJxMWIOj1O4QvB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEcBAABAgAGBQJLbO2vAAoJEDyn+gO8EoIo+uEH/AxQmJNQcDeIHNBhTfWK6XOt RtdshFGrBExWRfd2fnhzq2Dz01pnfswKjiKMwH/53BjqoScLwcV+YWzYv1+67Baq YcpJyjBYdML5FdY754YySJA1FD5Xf2PMUTsTIhnuJXszZipsgRB/IEkCt4mrR4FQ Z5xyCoeZGbKVqr+PIfQQocBjm0+0X2bFrjoKyY4+bV52Axatzv1EfmfyopV8Bc5q sVnYlNIuDC2AHkrCtTOTEOFAZnTaO/RI7vNI/0NWExTRAu1DLnRp9j0OBbR2G3Ok OoqCIjqueAr7ZI37u9RSWqLa4f0Ybtorv2oG4u/M7POfZBdw3qCaxGSjlO9zJEU= =o/HH -----END PGP SIGNATURE----- --=-+bloULqJxMWIOj1O4QvB-- --===============3735426995338270295== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com --===============3735426995338270295== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel --===============3735426995338270295==--