Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NkLhD-0003lW-7A for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:51 -0500 Received: from [199.232.76.173] (port=35980 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkLhB-0003kT-9I for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:49 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NkLh4-0001PL-Cx for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:48 -0500 Received: from oxygen.pond.sub.org ([213.239.205.148]:37816) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NkLh2-0001OF-Rs for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:10:41 -0500 Received: from blackfin.pond.sub.org (pD9E38C12.dip.t-dialin.net [217.227.140.18]) by oxygen.pond.sub.org (Postfix) with ESMTPA id B86102DD31A for ; Wed, 24 Feb 2010 19:04:30 +0100 (CET) From: Markus Armbruster Date: Wed, 24 Feb 2010 18:55:59 +0100 Message-Id: <1267034160-3517-48-git-send-email-armbru@redhat.com> In-Reply-To: <1267034160-3517-1-git-send-email-armbru@redhat.com> References: <1267034160-3517-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH RFC 47/48] monitor: Use argument type 'O' for device_add List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org While there, improve the params help text. Signed-off-by: Markus Armbruster --- hw/qdev.c | 3 +-- qemu-monitor.hx | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 80a027a..bcd989c 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -766,8 +766,7 @@ void do_device_add(Monitor *mon, const QDict *qdict) { QemuOpts *opts; - opts = qemu_opts_parse(&qemu_device_opts, - qdict_get_str(qdict, "config"), 1); + opts = qemu_opts_from_qdict(&qemu_device_opts, qdict); if (opts) { if (qdev_device_help(opts) || qdev_device_add(opts) == NULL) { qemu_opts_del(opts); diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 7f9d261..641a8ef 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -570,8 +570,8 @@ ETEXI { .name = "device_add", - .args_type = "config:s", - .params = "device", + .args_type = "device:O", + .params = "driver[,prop=value],[,...]", .help = "add device, like -device on the command line", .mhandler.cmd = do_device_add, }, -- 1.6.6