From: "Michael Chan" Subject: Re: [PATCH net-next 3/6] cnic: Fix panic in cnic_iscsi_nl_msg_recv() when device is down. Date: Fri, 26 Feb 2010 11:11:09 -0800 Message-ID: <1267211469.19491.8.camel@nseg_linux_HP1.broadcom.com> References: <20100226005114.GH3876@verge.net.au> <20100226184001.GJ6733@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "'Simon Horman'" , "davem@davemloft.net" , "netdev@vger.kernel.org" To: "paulmck@linux.vnet.ibm.com" Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4671 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965841Ab0BZTWx (ORCPT ); Fri, 26 Feb 2010 14:22:53 -0500 In-Reply-To: <20100226184001.GJ6733@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2010-02-26 at 10:40 -0800, Paul E. McKenney wrote: > On Thu, Feb 25, 2010 at 11:01:59PM -0800, Michael Chan wrote: > > Simon Horman wrote: > > > > > On Wed, Feb 24, 2010 at 04:42:06PM -0800, Michael Chan wrote: > > > > Some data structures are freed when the device is down and it will > > > > crash if an ISCSI netlink message is received. Add RCU protection > > > > to prevent this. In the shutdown path, ulp_ops[CNIC_ULP_L4] is > > > > assigned NULL and rcu_synchronized before freeing the data > > > > structures. > > > > > > Is rcu_assign_pointer() unnecessary in cnic_cm_open()? > > > It doesn't seem to be followed by rcu_synchronized() and the pointer > > > doesn't seem to be accessible anywhere else at that time. > > > > We assign a valid pointer in cnic_cm_open() so that it can be used > > during run-time (in service_kcqes() for example). During shutdown in > > cnic_stop_hw(), we assign NULL followed by rcu_synchronize(). > > So you are saying that when the pointer is assigned in cnic_cm_open(), > there cannot possibly be any concurrent reading threads? Right. The hardware has not been started yet so there will be no events to process from the hardware. The pointer is read when processing these hardware events. > > Use of an explicit rcu_assign_pointer() would be better if so. Yes, we use rcu_assign_pointer in cnic_cm_open() when assigning the valid pointer in cnic_cm_open(). Thanks.