Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ntf1c-0002Zf-7Z for qemu-devel@nongnu.org; Mon, 22 Mar 2010 06:38:24 -0400 Received: from [199.232.76.173] (port=51647 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ntf1a-0002ZX-LJ for qemu-devel@nongnu.org; Mon, 22 Mar 2010 06:38:22 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ntf1W-0001Sh-A6 for qemu-devel@nongnu.org; Mon, 22 Mar 2010 06:38:22 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]:37818) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ntf1V-0001SF-RW for qemu-devel@nongnu.org; Mon, 22 Mar 2010 06:38:18 -0400 Received: from blackfin.pond.sub.org (pD951ABC6.dip.t-dialin.net [217.81.171.198]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 56448276D6D for ; Mon, 22 Mar 2010 11:38:15 +0100 (CET) From: Markus Armbruster Date: Mon, 22 Mar 2010 11:38:13 +0100 Message-Id: <1269254294-23876-2-git-send-email-armbru@redhat.com> In-Reply-To: <1269254294-23876-1-git-send-email-armbru@redhat.com> References: <1269254294-23876-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/2] qdev: Convert qdev_unplug() to QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com Note: our device unplug methods don't need conversion work, because they can't currently fail. Signed-off-by: Markus Armbruster --- hw/qdev.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index f45ed0f..c521115 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -287,8 +287,7 @@ int qdev_init(DeviceState *dev) int qdev_unplug(DeviceState *dev) { if (!dev->parent_bus->allow_hotplug) { - error_report("Bus %s does not support hotplugging", - dev->parent_bus->name); + qerror_report(QERR_BUS_NO_HOTPLUG, dev->parent_bus->name); return -1; } assert(dev->info->unplug != NULL); -- 1.6.6.1