Content-Type: multipart/mixed; boundary="===============4408691434225455792=="
MIME-Version: 1.0
From: Marcel Holtmann <marcel@holtmann.org>
Subject: Re: Issue with PPP auth and empty username/password
Date: Fri, 26 Mar 2010 23:01:03 -0700
Message-ID: <1269669663.11714.192.camel@localhost.localdomain>
In-Reply-To: <20100326213605.47c235de@kcaccard-MOBL3>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============4408691434225455792==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Kristen,

> > > I started tested the PPP code and run into a simple crash when not
> > > providing username and password. This should be possible.
> > > =

> > > Program terminated with signal 11, Segmentation fault.
> > > #0  0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
> > > (gdb) bt
> > > #0  0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
> > > #1  0x000000000040ca9b in chap_process_challenge (priv=3D0x15a6bf0, n=
ew_packet=3D0x15a5164 "\001\001")
> > >     at gatchat/ppp_auth.c:86
> > > #2  chap_process_packet (priv=3D0x15a6bf0, new_packet=3D0x15a5164 "\0=
01\001") at gatchat/ppp_auth.c:143
> > > #3  0x000000000040a66f in ppp_recv (channel=3D<value optimized out>, =
cond=3D<value optimized out>, data=3D0x15a6d50)
> > >     at gatchat/ppp.c:205
> > > #4  ppp_feed (channel=3D<value optimized out>, cond=3D<value optimize=
d out>, data=3D0x15a6d50) at gatchat/ppp.c:286
> > > #5  ppp_cb (channel=3D<value optimized out>, cond=3D<value optimized =
out>, data=3D0x15a6d50) at gatchat/ppp.c:340
> > > #6  0x0000003598a3923e in g_main_context_dispatch () from /lib64/libg=
lib-2.0.so.0
> > > #7  0x0000003598a3cc28 in ?? () from /lib64/libglib-2.0.so.0
> > > #8  0x0000003598a3d075 in g_main_loop_run () from /lib64/libglib-2.0.=
so.0
> > > #9  0x0000000000403918 in main (argc=3D1, argv=3D0x7fff7b97eb28) at g=
atchat/gsmdial.c:624
> > =

> > your patches haven't fixed this yet.
> > =

> > Core was generated by `./gatchat/gsmdial -n /dev/ttyUSB0 -c 1 -a intern=
et.com -l -P'.
> > Program terminated with signal 11, Segmentation fault.
> > #0  __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
> > 31		pcmpeqb	(%rdi), %xmm2
> > (gdb) bt
> > #0  __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
> > #1  0x000000000040d13b in chap_process_challenge (priv=3D0x211aba0, new=
_packet=3D0x2119b7c "\001\001")
> >     at gatchat/ppp_auth.c:86
> > #2  chap_process_packet (priv=3D0x211aba0, new_packet=3D0x2119b7c "\001=
\001") at gatchat/ppp_auth.c:143
> > #3  0x000000000040a94e in ppp_recv (channel=3D<value optimized out>, co=
nd=3D<value optimized out>, data=3D0x211bab0)
> >     at gatchat/ppp.c:210
> > #4  ppp_feed (channel=3D<value optimized out>, cond=3D<value optimized =
out>, data=3D0x211bab0) at gatchat/ppp.c:295
> > #5  ppp_cb (channel=3D<value optimized out>, cond=3D<value optimized ou=
t>, data=3D0x211bab0) at gatchat/ppp.c:347
> > #6  0x0000003598a3923e in g_main_dispatch (context=3D0x2118160) at gmai=
n.c:1960
> > #7  IA__g_main_context_dispatch (context=3D0x2118160) at gmain.c:2513
> > #8  0x0000003598a3cc28 in g_main_context_iterate (context=3D0x2118160, =
block=3D<value optimized out>, =

> >     dispatch=3D<value optimized out>, self=3D<value optimized out>) at =
gmain.c:2591
> > #9  0x0000003598a3d075 in IA__g_main_loop_run (loop=3D0x21183b0) at gma=
in.c:2799
> > #10 0x0000000000403a25 in main (argc=3D1, argv=3D0x7fffa4947bf8) at gat=
chat/gsmdial.c:679
>
> I notice that you finally applied my patch to allow the empty secrets.  =

> Are you still having a problem after applying that patch?

actually it never made it to me. I was missing patch 1/2 from your one
submission. That is why I asked you to re-send it. In the end I started
going through the code and fixed it by myself.

Regards

Marcel



--===============4408691434225455792==--