Return-Path: Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1OHUJt-000458-D5 for ltp-list@lists.sourceforge.net; Thu, 27 May 2010 04:03:45 +0000 Received: from e28smtp05.in.ibm.com ([122.248.162.5]) by sfi-mx-1.v28.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1OHUJq-0003mE-F5 for ltp-list@lists.sourceforge.net; Thu, 27 May 2010 04:03:45 +0000 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by e28smtp05.in.ibm.com (8.14.3/8.13.1) with ESMTP id o4R43XJr031916 for ; Thu, 27 May 2010 09:33:33 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4R43XFR3207228 for ; Thu, 27 May 2010 09:33:33 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4R43WI7031945 for ; Thu, 27 May 2010 14:03:33 +1000 From: Gowrishankar Date: Thu, 27 May 2010 09:33:26 +0530 Message-Id: <1274933006-4754-6-git-send-email-gomuthuk@linux.vnet.ibm.com> In-Reply-To: References: Subject: [LTP] [PATCH 5/5] realtime: code cleanup on pi-test 6 List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Linux Test Project Cc: gowrishankar From: gowrishankar This patch cleans up the test so as to follow C coding style standards. Signed-off-by: Gowrishankar Tested-by: Gowrishankar Acked-by: John Stultz Acked-by: Darren Hart --- testcases/realtime/func/pi-tests/testpi-6.c | 72 ++++++++++++++------------- 1 files changed, 37 insertions(+), 35 deletions(-) diff --git a/testcases/realtime/func/pi-tests/testpi-6.c b/testcases/realtime/func/pi-tests/testpi-6.c index 560f45f..523ba13 100644 --- a/testcases/realtime/func/pi-tests/testpi-6.c +++ b/testcases/realtime/func/pi-tests/testpi-6.c @@ -30,6 +30,7 @@ * * * HISTORY + * 2010-04-22 Code cleanup by Gowrishankar * * *****************************************************************************/ @@ -39,54 +40,55 @@ #include #include #include -pthread_mutex_t child_mutex; +pthread_mutex_t child_mutex; -void* child_thread (void* arg) +void *child_thread(void *arg) { - int ret; + int ret; - ret = pthread_mutex_lock(&child_mutex); - if (ret != 0) - printf("child thread: Failed to lock child_mutex: %d\n", ret); - else - printf("child_thread: got lock\n"); + ret = pthread_mutex_lock(&child_mutex); + if (ret != 0) + printf("child thread: Failed to lock child_mutex: %d\n", ret); + else + printf("child_thread: got lock\n"); - sleep(2); + sleep(2); - printf("child_thread: Trying to get lock 2nd time\n"); - ret = pthread_mutex_lock(&child_mutex); - if (ret != 0) - printf("child thread: Failed to lock child_mutex: %d\n", ret); - else - printf("child_thread: got lock 2nd time !!\n"); + printf("child_thread: Trying to get lock 2nd time\n"); + ret = pthread_mutex_lock(&child_mutex); + if (ret != 0) + printf("child thread: Failed to lock child_mutex: %d\n", ret); + else + printf("child_thread: got lock 2nd time !!\n"); - return NULL; + return NULL; } int do_test(int argc, char **argv) { - pthread_mutexattr_t mutexattr; - int retc, robust; + pthread_mutexattr_t mutexattr; + int retc, robust; - if (pthread_mutexattr_init(&mutexattr) != 0) { - printf("Failed to init mutexattr\n"); - }; - if (pthread_mutexattr_setrobust_np(&mutexattr, PTHREAD_MUTEX_ROBUST_NP) != 0) { - printf("Can't set robust mutex\n"); - } - if (pthread_mutexattr_getrobust_np(&mutexattr, &robust) != 0) { - printf("Can't get mutexattr protocol\n"); - } else { - printf("robust in mutexattr is %d\n", robust); - } - if ((retc = pthread_mutex_init(&child_mutex, &mutexattr)) != 0) { - printf("Failed to init mutex: %d\n", retc); - } + if (pthread_mutexattr_init(&mutexattr) != 0) + printf("Failed to init mutexattr\n"); - create_other_thread(child_thread, NULL); - join_threads(); + if (pthread_mutexattr_setrobust_np(&mutexattr,\ + PTHREAD_MUTEX_ROBUST_NP) != 0) + printf("Can't set robust mutex\n"); - return 0; + if (pthread_mutexattr_getrobust_np(&mutexattr, &robust) != 0) + printf("Can't get mutexattr protocol\n"); + else + printf("robust in mutexattr is %d\n", robust); + + retc = pthread_mutex_init(&child_mutex, &mutexattr); + if (retc != 0) + printf("Failed to init mutex: %d\n", retc); + + create_other_thread(child_thread, NULL); + join_threads(); + + return 0; } #include "test-skeleton.c" -- 1.7.1 ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list