From: Peter Tyser Date: Tue, 01 Jun 2010 10:26:25 -0500 Subject: [U-Boot] [PATCH 03/10] 83xx/85xx/86xx: LBC register cleanup In-Reply-To: <1275083125-15208-4-git-send-email-beckyb@kernel.crashing.org> References: <1275083125-15208-1-git-send-email-beckyb@kernel.crashing.org> <1275083125-15208-2-git-send-email-beckyb@kernel.crashing.org> <1275083125-15208-3-git-send-email-beckyb@kernel.crashing.org> <1275083125-15208-4-git-send-email-beckyb@kernel.crashing.org> Message-ID: <1275405985.2469.8632.camel@petert> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Becky, On Fri, 2010-05-28 at 16:45 -0500, Becky Bruce wrote: > --- a/arch/powerpc/include/asm/config.h > +++ b/arch/powerpc/include/asm/config.h > @@ -76,4 +76,7 @@ > /* Relocation to SDRAM works on all PPC boards */ > #define CONFIG_RELOC_FIXUP_WORKS > > +/* Currently all plats have a local bus controller */ > +#define CONFIG_FSL_LBC > + The above doesn't appear to break anything, but it seems a bit odd to define CONFIG_FSL_LBC for all PPC boards. Would it be possible to only define CONFIG_FSL_LBC and CONFIG_FSL_ELBC in config.h based on some CONFIG_MPCyyy conditionals and then get rid of patch 1/10 in this series? If not, maybe CONFIG_FSL_LBC should be protected by a "#if defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx...", or moved down into board config files similar to CONFIG_FSL_ELBC to prevent it from appearing for every PPC board. Best, Peter