From: "Justin P. Mattock" Subject: [PATCH 5/8 v2]drm:drm_gem Fix warning: variable 'dev' set but not used Date: Mon, 21 Jun 2010 15:27:29 -0700 Message-ID: <1277159249-22007-1-git-send-email-justinmattock@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-px0-f177.google.com (mail-px0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 674BA9E821 for ; Mon, 21 Jun 2010 15:27:46 -0700 (PDT) Received: by pxi13 with SMTP id 13so584528pxi.36 for ; Mon, 21 Jun 2010 15:27:46 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: airlied@redhat.com, linux-kernel@vger.kernel.org, "Justin P. Mattock" List-Id: dri-devel@lists.freedesktop.org This is a redu due to the original being completly wrong (better to leave a warning than shut it off). I've removed the "dev =" variable but then receive a drm_gem.c:207:2: warning: statement with no effect telling me this thing is not doing anything according to gcc so the below patch fixes a warning from gcc: CC [M] drivers/gpu/drm/drm_gem.o drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete': drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used have a look if you have the time, and if theres something else to do then let me know(i'll test it out!!) Signed-off-by: Justin P. Mattock --- drivers/gpu/drm/drm_gem.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 33dad3f..d1648bf 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c @@ -185,7 +185,6 @@ EXPORT_SYMBOL(drm_gem_object_alloc); static int drm_gem_handle_delete(struct drm_file *filp, u32 handle) { - struct drm_device *dev; struct drm_gem_object *obj; /* This is gross. The idr system doesn't let us try a delete and @@ -205,7 +204,6 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle) spin_unlock(&filp->table_lock); return -EINVAL; } - dev = obj->dev; /* Release reference and decrement refcount. */ idr_remove(&filp->object_idr, handle); -- 1.7.1.rc1.21.gf3bd6