From: Adam Jackson Subject: Re: [PATCH] i915: fix ironlake edp panel setup (v2) Date: Tue, 29 Jun 2010 09:47:04 -0400 Message-ID: <1277819224.2586.48.camel@atropine> References: <1277682314-20396-1-git-send-email-airlied@gmail.com> <20100628060456.GC10521@zhen-devel.sh.intel.com> <20100629084443.GH10521@zhen-devel.sh.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1171306824==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id A9B349E7BE for ; Tue, 29 Jun 2010 06:47:07 -0700 (PDT) In-Reply-To: <20100629084443.GH10521@zhen-devel.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1171306824== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-N13PTQ/vYKrLH20/kT7V" --=-N13PTQ/vYKrLH20/kT7V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2010-06-29 at 16:44 +0800, Zhenyu Wang wrote: > On 2010.06.28 14:04:56 +0800, Zhenyu Wang wrote: > >=20 > > sorry, this is still broken on the 16x9 panel.=20 > >=20 > > 'intel_dp_link_required' is 107840*18/8 =3D 242640, 'intel_dp_max_data_= rate' is > > 270000*1*8/10 =3D 216000. So it will fail in both check. >=20 > Dave, here's dmesg in working (upstream) and your patch applied cases. > Sorry, this panel does have EDID but is invalid. That's not "has invalid EDID", that's "really doesn't have EDID at all". Might be DisplayID! Any chance you can try a patch like this and give me the dmesg? It'll still look like an EDID failure but it should be something more interesting than cc cc cc cc ... diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index bd74b3f..16beed2 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -201,7 +201,7 @@ bool drm_edid_is_valid(struct edid *edid) } EXPORT_SYMBOL(drm_edid_is_valid); =20 -#define DDC_ADDR 0x50 +#define DDC_ADDR 0x52 #define DDC_SEGMENT_ADDR 0x30 /** * Get EDID information via I2C. - ajax --=-N13PTQ/vYKrLH20/kT7V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkwp+VgACgkQW4otUKDs0NO4dwCg5fljSbX+4LMq6RdIL1O17JS2 utkAoMd/hy+frZOKKIwA/3SG4ChMIYzo =NYZ2 -----END PGP SIGNATURE----- --=-N13PTQ/vYKrLH20/kT7V-- --===============1171306824== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1171306824==--