From: Alessandro Bono Subject: Re: [PATCH] increase MAX_NICS value Date: Mon, 12 Jul 2010 14:54:51 +0200 Message-ID: <1278939291.9543.6.camel@champagne> References: <1278689957.9187.12.camel@champagne> <201007091230.58502.iggy@theiggy.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Brian Jackson Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:34022 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441Ab0GLMyy (ORCPT ); Mon, 12 Jul 2010 08:54:54 -0400 Received: by wyf23 with SMTP id 23so3276441wyf.19 for ; Mon, 12 Jul 2010 05:54:53 -0700 (PDT) In-Reply-To: <201007091230.58502.iggy@theiggy.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2010-07-09 at 12:30 -0500, Brian Jackson wrote: > On Friday, July 09, 2010 10:39:17 am Alessandro Bono wrote: > > Hi all > > > > max number of allowed nics per vm is hardcoded on net.h to 8. This value > > it's too low in situation with big network, increase to 24 > > this should be safe as mentioned on this thread > > http://kerneltrap.org/mailarchive/linux-kvm/2009/1/29/4848304/thread > > > A better long term solution might be to convert it to QLIST or something > instead of hardcoding the array size. Sure my patch it's simply a better default value and solve the problem for big network. Obviously a dynamic structure it's best suited for this information > > > > > > Signed-off-by: Alessandro Bono > > > > --- net.h.old 2010-07-09 17:30:39.542170103 +0200 > > +++ net.h 2010-07-09 17:30:48.842166029 +0200 > > @@ -121,7 +121,7 @@ > > > > /* NIC info */ > > > > -#define MAX_NICS 8 > > +#define MAX_NICS 24 > > > > struct NICInfo { > > uint8_t macaddr[6]; -- Cordiali Saluti Alessandro Bono