From: Artem Bityutskiy Subject: [PATCH 1/3] writeback: remove redundant list initialization Date: Mon, 12 Jul 2010 18:22:19 +0300 Message-ID: <1278948141-2400-2-git-send-email-dedekind1@gmail.com> References: <1278948141-2400-1-git-send-email-dedekind1@gmail.com> Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Jens Axboe Return-path: Received: from smtp.nokia.com ([192.100.105.134]:61857 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397Ab0GLPZ7 (ORCPT ); Mon, 12 Jul 2010 11:25:59 -0400 In-Reply-To: <1278948141-2400-1-git-send-email-dedekind1@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Artem Bityutskiy We do not have to call 'INIT_LIST_HEAD()' for list elements ('bdi->bdi_list') before inserting them to the 'bdi_pending_list', because 'list_add_tail' will initialize the element anyway. Thus, kill the redundant initialization. Signed-off-by: Artem Bityutskiy --- mm/backing-dev.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 15378db..2df2af6 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -416,7 +416,6 @@ static void bdi_add_to_pending(struct rcu_head *head) struct backing_dev_info *bdi; bdi = container_of(head, struct backing_dev_info, rcu_head); - INIT_LIST_HEAD(&bdi->bdi_list); spin_lock(&bdi_lock); list_add_tail(&bdi->bdi_list, &bdi_pending_list); -- 1.7.1.1