From: Jan Kara Subject: [PATCH 1/3] mm: Stop background writeback if there is other work queued for the thread Date: Tue, 3 Aug 2010 18:20:38 +0200 Message-ID: <1280852440-13630-2-git-send-email-jack@suse.cz> References: <1280852440-13630-1-git-send-email-jack@suse.cz> Cc: Wu Fengguang , linux-fsdevel@vger.kernel.org, Jens Axboe , Jan Kara To: Andrew Morton Return-path: Received: from cantor2.suse.de ([195.135.220.15]:59053 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756000Ab0HCQVU (ORCPT ); Tue, 3 Aug 2010 12:21:20 -0400 In-Reply-To: <1280852440-13630-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Background writeback and kupdate-style writeback are easily livelockable (from a definition of their target). This is inconvenient because it can make sync(1) stall forever waiting on its queued work to be finished. Fix the problem by interrupting background and kupdate writeback if there is some other work to do. We can return to them after completing all the queued work. Reviewed-by: Wu Fengguang Signed-off-by: Jan Kara --- fs/fs-writeback.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index d5be169..542471e 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -633,6 +633,14 @@ static long wb_writeback(struct bdi_writeback *wb, break; /* + * Background writeout and kupdate-style writeback are + * easily livelockable. Stop them if there is other work + * to do so that e.g. sync can proceed. + */ + if ((work->for_background || work->for_kupdate) && + !list_empty(&wb->bdi->work_list)) + break; + /* * For background writeout, stop when we are below the * background dirty threshold */ -- 1.6.4.2