From: Adam Jackson Subject: Re: [PATCH 1/2] drm/i915: Include a generation number in the device info Date: Wed, 11 Aug 2010 10:14:44 -0400 Message-ID: <1281536084.17843.3056.camel@atropine> References: <20100810143753.2c6f6f8e@virtuousgeek.org> <1281518747-5085-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1713102166==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id E749E9E7B1 for ; Wed, 11 Aug 2010 07:14:53 -0700 (PDT) In-Reply-To: <1281518747-5085-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1713102166== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-3rx0twX5Yrz10bvDoXld" --=-3rx0twX5Yrz10bvDoXld Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2010-08-11 at 10:25 +0100, Chris Wilson wrote: > To simplify the IS_GEN[234] macros and to enable switching. I think your three cent titanium tax doesn't go too far enough. 830, 845g, 85x, and 865 all now have .gen =3D 2, .is_i8xx =3D 1, and nothing later has .is_i8xx, so that field can just go. Indeed you do: > #define IS_I865G(dev) ((dev)->pci_device =3D=3D 0x2572) > -#define IS_GEN2(dev) (INTEL_INFO(dev)->is_i8xx) > #define IS_I915G(dev) (INTEL_INFO(dev)->is_i915g) which appears to be the only reference. Likewise, all the gen[3456] parts have .is_i9xx =3D 1, so you could do: -#define IS_I9XX(dev) (INTEL_INFO(dev)->is_i9xx) +#define IS_I9XX(dev) (INTEL_INFO(dev)->gen > 2) and drop .is_i9xx. - ajax --=-3rx0twX5Yrz10bvDoXld Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkxisFQACgkQW4otUKDs0NOUiACfWBJK+GB9+GZNTdxEN6vl0YJB 1rkAoKKeOX7bor/LmtgQPmyxuUSEFrYv =tD40 -----END PGP SIGNATURE----- --=-3rx0twX5Yrz10bvDoXld-- --===============1713102166== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1713102166==--