From: Adam Jackson Subject: Re: [PATCH 3/5] drm/i915: fix VGA plane disable for Ironlake+ Date: Mon, 16 Aug 2010 10:13:18 -0400 Message-ID: <1281967998.17843.12572.camel@atropine> References: <1281740635-3016-1-git-send-email-jbarnes@virtuousgeek.org> <1281740635-3016-4-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0219255466==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 692B49E7F7 for ; Mon, 16 Aug 2010 07:13:20 -0700 (PDT) In-Reply-To: <1281740635-3016-4-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0219255466== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-GT+9KbkvaDFo9rnyKEue" --=-GT+9KbkvaDFo9rnyKEue Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2010-08-13 at 16:03 -0700, Jesse Barnes wrote: > We need to use I/O port instructions to access VGA registers on > Ironlake+, and it doesn't hurt on other platforms, so switch the VGA > plane disable function over to using them. Move it to init time as well > while we're at it, no need to repeatedly disable the VGA plane with > every mode set and DPMS event. This is missing a vga_get()/vga_put() pair. - ajax --=-GT+9KbkvaDFo9rnyKEue Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkxpR34ACgkQW4otUKDs0NMgewCbB09K8QoqxZdM+8C5epmEIl1D 7zQAoOikh14xaDIU7Ud9Rd7OKaa1ck4F =qqiP -----END PGP SIGNATURE----- --=-GT+9KbkvaDFo9rnyKEue-- --===============0219255466== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0219255466==--