From: Jan Kara Subject: [PATCH 1/1] vfs: update ctime when changing the file's permission by setfacl Date: Tue, 17 Aug 2010 12:42:13 +0200 Message-ID: <1282041733-4744-1-git-send-email-jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, Jan Kara , Al Viro To: Al Viro Return-path: Received: from cantor.suse.de ([195.135.220.2]:33171 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025Ab0HQKmz (ORCPT ); Tue, 17 Aug 2010 06:42:55 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: generic_acl_set didn't update the ctime of the file when its permission was changed. Steps to reproduce: # touch aaa # stat -c %Z aaa 1275289822 # setfacl -m 'u::x,g::x,o::x' aaa # stat -c %Z aaa 1275289822 <- unchanged But, according to the spec of the ctime, vfs must update it. Port of ext3 patch by Miao Xie . CC: Al Viro Signed-off-by: Jan Kara --- fs/generic_acl.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) Al, would you merge this fix please? You didn't seem to pick it up last time I sent it. Thanks. diff --git a/fs/generic_acl.c b/fs/generic_acl.c index 99800e5..6bc9e3a 100644 --- a/fs/generic_acl.c +++ b/fs/generic_acl.c @@ -94,6 +94,7 @@ generic_acl_set(struct dentry *dentry, const char *name, const void *value, if (error < 0) goto failed; inode->i_mode = mode; + inode->i_ctime = CURRENT_TIME; if (error == 0) { posix_acl_release(acl); acl = NULL; -- 1.6.4.2