From: Gianni Tedesco Subject: Re: [PATCH,v2] xl: randomly generate UUID's Date: Fri, 20 Aug 2010 16:09:59 +0100 Message-ID: <1282316999.3731.64.camel@qabil.uk.xensource.com> References: <1281970136.18490.395.camel@qabil.uk.xensource.com> <201008161705.29426.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201008161705.29426.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: Ian Campbell , Xen Devel , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, 2010-08-16 at 16:05 +0100, Christoph Egger wrote: > On Monday 16 August 2010 16:48:56 Gianni Tedesco wrote: > > This patch converts xl to randomly generate UUID's rather than using a > > dodgy time-seeded PRNG. I have incorporated Cristoph Eggers suggestions > > wrt. portability so I would be grateful for an ACK on the NetBSD side of > > things. This also folds in the "v2: xl: make libxl_uuid2string internal > > to libxenlight" patch since it couldn't be avoided in fixing up xl > > printfs() which grok around in the uuid type directly. > > > > I have ignored various suggestions so far on auto-generation of MAC > > addresses and left it as a topic for a future patch to solve. In other > > words the behaviour stays the same it's just using a true random source. > > > > This will probably conflict horribly with "libxl: autogenerate type > > definitions and destructor functions" so if it's acked in principle I > > can re-base and re-send on top of that. > > Please do. The patch looks almost good to me - see line comments - > I would like to compile-test it at least on NetBSD before acknowledging > the patch. > > Christoph > > > > > Signed-off-by: Gianni Tedesco > > > > diff -r 85bd0f6e8fed tools/libxl/Makefile > > --- a/tools/libxl/Makefile Fri Aug 13 13:55:51 2010 +0100 > > +++ b/tools/libxl/Makefile Mon Aug 16 15:39:13 2010 +0100 > > @@ -16,6 +16,9 @@ CFLAGS += -I. -fPIC > > CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) > > $(CFLAGS_libblktapctl) > > > > LIBS = $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) > > $(LDLIBS_libblktapctl) $(UTIL_LIBS) > > +ifeq ($(CONFIG_Linux),y) > > +LIBS += -luuid > > +endif > > This is not needed because $(UTIL_LIBS) already covers that case. Not sure what you mean by this, if I omit that linen the I get link errors. That's the way it's done in tools/blktap2/ and I just copied that. Am about to re-base and re-send this patch so please clarify if this is indeed wrong for some reason.