Received: from [140.186.70.92] (port=49527 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtLWq-0004Fr-Rm for qemu-devel@nongnu.org; Wed, 08 Sep 2010 10:21:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtLWk-0007Ao-WE for qemu-devel@nongnu.org; Wed, 08 Sep 2010 10:21:36 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:47828) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtLWk-0007Ai-RH for qemu-devel@nongnu.org; Wed, 08 Sep 2010 10:21:30 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o88EBB5T002041 for ; Wed, 8 Sep 2010 08:11:11 -0600 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o88ELSo4110464 for ; Wed, 8 Sep 2010 08:21:28 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o88ELRMX016803 for ; Wed, 8 Sep 2010 08:21:28 -0600 From: Adam Litke Date: Wed, 8 Sep 2010 09:21:25 -0500 Message-Id: <1283955685-25152-1-git-send-email-agl@us.ibm.com> Subject: [Qemu-devel] [PATCH] [For 0.13] Disable virtio-balloon memory stats interface List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , Anthony Liguori Cc: Adam Litke , Paolo Bonzini , Luiz Capitulino , qemu list , Markus Armbruster The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor. To fix this regression, the virtio balloon memory stats feature is being disabled in qemu-0.13. Signed-off-by: Adam Litke --- hw/virtio-balloon.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index 9fe3886..269bc22 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon.c @@ -190,7 +190,17 @@ static void virtio_balloon_set_config(VirtIODevice *vdev, static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f) { - f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); + /* + * The addition of memory stats reporting to the virtio balloon causes + * the 'info balloon' command to become asynchronous. This is a regression + * because in some cases it can hang the user monitor. + * + * To fix this regression, the virtio balloon memory stats feature is being + * disabled in qemu-0.13. + * + * -aglitke + */ + /* f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); */ return f; } -- 1.6.1.3