From: Gianni Tedesco Subject: Re: [PATCH,v2]: xl: don't free string literals Date: Wed, 8 Sep 2010 17:59:01 +0100 Message-ID: <1283965141.20276.183.camel@qabil.uk.xensource.com> References: <1283963489.20276.180.camel@qabil.uk.xensource.com> <1283964401.14311.1969.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1283964401.14311.1969.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Xen Devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Wed, 2010-09-08 at 17:46 +0100, Ian Campbell wrote: > On Wed, 2010-09-08 at 17:31 +0100, Gianni Tedesco wrote: > > > > /* then process config related to dm */ > > - if (!xlu_cfg_get_string (config, "device_model", &buf)) > > - dm_info->device_model = strdup(buf); > > + !xlu_cfg_replace_string (config, "device_model", > > &dm_info->device_model); > > Stray ! at the start of the new line? Indeed. Jackson, I can re-post this or probably easier for you to fix up manually before committing? Gianni