From: Gianni Tedesco Subject: [PATCH]: xl: fix double free of domain names Date: Fri, 10 Sep 2010 15:10:49 +0100 Message-ID: <1284127849.17452.136.camel@qabil.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xen Devel Cc: Ian Campbell , Ian Jackson List-Id: xen-devel@lists.xenproject.org Assigning malloc'd variables from one structure to another when both of them are free'd via destructors is a bad idea. Let's use a strdup. Signed-off-by: Gianni Tedesco diff -r ef2d0a9b2036 tools/libxl/xl_cmdimpl.c --- a/tools/libxl/xl_cmdimpl.c Fri Sep 10 14:59:29 2010 +0100 +++ b/tools/libxl/xl_cmdimpl.c Fri Sep 10 15:10:32 2010 +0100 @@ -296,7 +296,7 @@ static void init_dm_info(libxl_device_mo libxl_uuid_generate(&dm_info->uuid); - dm_info->dom_name = c_info->name; + dm_info->dom_name = strdup(c_info->name); dm_info->device_model = strdup("qemu-dm"); dm_info->videoram = b_info->video_memkb / 1024; dm_info->apic = b_info->u.hvm.apic;