From: Peter Tyser Date: Mon, 13 Sep 2010 09:53:05 -0500 Subject: [U-Boot] [PATCH] powerpc: Cleanup BOOTFLAG_* usage In-Reply-To: <201009130827.21823.sr@denx.de> References: <1284355310-25449-1-git-send-email-ptyser@xes-inc.com> <20100913053440.7BAE815242D@gemini.denx.de> <201009130827.21823.sr@denx.de> Message-ID: <1284389585.26713.2967.camel@petert> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2010-09-13 at 08:27 +0200, Stefan Roese wrote: > On Monday 13 September 2010 07:34:40 Wolfgang Denk wrote: > > > BOOTFLAG_COLD and BOOTFLAG_WARM have identical definitions for every > > > PowerPC board, so share a common definition. > > > > > > Signed-off-by: Peter Tyser > > > --- > > > It looks like there are only a few boards (5) that use the warm/cold > > > boot concept, maybe we should remove this largely unused feature? > > > Or at least remove it for most CPU types? Is anyone out there > > > using it? > > > > I added this with the very first versions of PPCBoot, more than a > > decade ago. I've never seen it really used in the code. > > > > I vote for removing it. > > Me too: > > Acked-by: Stefan Roese Sounds good, I'll resubmit. Getting rid of the BOOTFLAG_* defines will make bd->bi_bootflags unused. What's the policy on modifying the bd_info structure? Leave an unused bi_bootflags field to prevent breakage of OSes? Best, Peter