From: Gianni Tedesco Subject: Re: [PATCH / 4.0.1] fix fd leak in xenstore Date: Tue, 14 Sep 2010 16:11:09 +0100 Message-ID: <1284477069.1914.7.camel@qabil.uk.xensource.com> References: <20100914143732.GA23420@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100914143732.GA23420@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Tue, 2010-09-14 at 15:37 +0100, Olaf Hering wrote: > Missing from commit 'libxl: Backported stuff from unstable' > Without this change, xs_daemon_open/xs_daemon_close will leak filedescriptors. > > Signed-off-by: Olaf Hering > > --- > tools/xenstore/xs.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- xen-4.0.1-testing.orig/tools/xenstore/xs.c > +++ xen-4.0.1-testing/tools/xenstore/xs.c > @@ -285,6 +285,8 @@ void xs_daemon_close(struct xs_handle *h > mutex_unlock(&h->request_mutex); > mutex_unlock(&h->reply_mutex); > mutex_unlock(&h->watch_mutex); > + > + close_fds_free(h); > } > > static bool read_all(int fd, void *data, unsigned int len) ack, well spotted Gianni