From: Adam Jackson Subject: Re: [PATCH] glx: Avoid use-after-free after drawableGone Date: Wed, 22 Sep 2010 11:21:52 -0400 Message-ID: <1285168912.4364.3066.camel@atropine> References: <1285156047-21138-1-git-send-email-jcristau@debian.org> <1285158749-9056-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0251215590==" Return-path: In-Reply-To: <1285158749-9056-1-git-send-email-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org Errors-To: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org To: Chris Wilson Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jcristau-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org List-Id: intel-gfx@lists.freedesktop.org --===============0251215590== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-MtagiOEfEiy4yrw5MMll" --=-MtagiOEfEiy4yrw5MMll Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2010-09-22 at 13:32 +0100, Chris Wilson wrote: > Becareful during list processing to keep valgrind quiet: >=20 > =3D=3D2989=3D=3D Invalid read of size 4 > =3D=3D2989=3D=3D at 0x48CE6B5: DrawableGone (glxext.c:168) > =3D=3D2989=3D=3D by 0x809F401: FreeResource (resource.c:601) > =3D=3D2989=3D=3D by 0x80845CE: ProcDestroyWindow (dispatch.c:733) > =3D=3D2989=3D=3D by 0x8087D76: Dispatch (dispatch.c:432) > =3D=3D2989=3D=3D by 0x8066439: main (main.c:291) > =3D=3D2989=3D=3D Address 0x55a9c1c is 76 bytes inside a block of size 88= free'd > =3D=3D2989=3D=3D at 0x4023B6A: free (vg_replace_malloc.c:366) > =3D=3D2989=3D=3D by 0x48D9DD8: __glXDRIcontextDestroy (glxdri2.c:250) > =3D=3D2989=3D=3D by 0x48CE1A0: __glXFreeContext (glxext.c:222) > =3D=3D2989=3D=3D by 0x48CE786: DrawableGone (glxext.c:165) > =3D=3D2989=3D=3D by 0x809F401: FreeResource (resource.c:601) > =3D=3D2989=3D=3D by 0x80845CE: ProcDestroyWindow (dispatch.c:733) > =3D=3D2989=3D=3D by 0x8087D76: Dispatch (dispatch.c:432) > =3D=3D2989=3D=3D by 0x8066439: main (main.c:291) >=20 > Reported-by: Julien Cristau > Signed-off-by: Chris Wilson > Cc: Kristian H=C3=B8gsberg Reviewed-by: Adam Jackson - ajax --=-MtagiOEfEiy4yrw5MMll Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkyaHxAACgkQW4otUKDs0NMbMACffzS2+opr/lUQNffzTa7Dpo+o lLYAn1QEpFX6xnF6ITBLGPFg7CRp33ru =qFyA -----END PGP SIGNATURE----- --=-MtagiOEfEiy4yrw5MMll-- --===============0251215590== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel --===============0251215590==--