From: Adam Jackson Subject: Re: [PATCH] DRM: ignore invalid EDID extensions Date: Wed, 22 Sep 2010 17:55:09 -0400 Message-ID: <1285192509.4364.3523.camel@atropine> References: <4C992B73.5040605@yahoo.co.uk> <1285189149.4364.3458.camel@atropine> <4C9A7857.2070004@yahoo.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0087991641==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 402799E779 for ; Wed, 22 Sep 2010 14:55:12 -0700 (PDT) In-Reply-To: <4C9A7857.2070004@yahoo.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sam Tygier Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0087991641== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-bFodR4+U7f5I02ME6Q8a" --=-bFodR4+U7f5I02ME6Q8a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2010-09-22 at 22:42 +0100, Sam Tygier wrote: > On 22/09/10 21:59, Adam Jackson wrote: > > On Tue, 2010-09-21 at 23:02 +0100, Sam Tygier wrote: > >> Currently an invalid EDID extension will cause the whole EDID to be > >> considered invalid. Instead just drop the extension, and return the > >> valid base block. The base block is modified to not claim to have > >> extensions, and update the checksum. > > > > This does not appear to be what your patch does. I mean, yes, if > > there's only one extension block, that's what it does, but if there's > > more than one... >=20 > I could modify it to skip the only invalid extension blocks. As my > monitor only claims to have 1 extension block, i could not test this > properly. I also spotted that I should make sure that my fix is not > run when the base block fails the checksum 4 times. May it should be > put within the for loop, replacing "goto carp;". Yeah, I hate to just drop extension blocks, but it's better than the alternative. They're optional for a reason I suppose. > >> For my EIZO S2242W the base block is fine, but the extension block is > >> all zeros. Without this patch I get no X and no VTs. > > > > I suspect what's actually happening there is that we're failing to get > > the extension block, not that it's being returned as zeros. >=20 > Could this be fixed? Anything I could try? Depends on what your driver is, I suspect. Did it ever work? - ajax --=-bFodR4+U7f5I02ME6Q8a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkyaez0ACgkQW4otUKDs0NNsQwCfUt4nYOBuS3L2UkpLijYUkB92 H60An2Y4ZYTrxY3GHb8m50Zks3wX6PXM =7gYw -----END PGP SIGNATURE----- --=-bFodR4+U7f5I02ME6Q8a-- --===============0087991641== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0087991641==--