From: York Sun Date: Tue, 28 Sep 2010 10:55:12 -0700 Subject: [U-Boot] [PATCH V2 1/7] Expand POST memory test to support arch-depended implementation. In-Reply-To: <20100928173130.CDDF9D52190@gemini.denx.de> References: <1285691891-32700-1-git-send-email-yorksun@freescale.com> <20100928173130.CDDF9D52190@gemini.denx.de> Message-ID: <1285696512.30239.14.camel@oslab-l1> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2010-09-28 at 19:31 +0200, Wolfgang Denk wrote: > > -int memory_post_test (int flags) > > +__attribute__((weak)) > > +int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset) > > phys_offset is unused here. Drop it? > The phys_offset is not used by _this_ weak function but it is used by another function implemented in the third patch. Is it OK to leave the unused phys_offset here? Regards, York