Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iT4P3-0003sU-UC for mharc-qemu-trivial@gnu.org; Fri, 08 Nov 2019 08:34:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56400) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT4P0-0003oT-Nm for qemu-trivial@nongnu.org; Fri, 08 Nov 2019 08:34:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT4Oz-00048U-J2 for qemu-trivial@nongnu.org; Fri, 08 Nov 2019 08:34:14 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41928 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iT4Oz-00047d-FB for qemu-trivial@nongnu.org; Fri, 08 Nov 2019 08:34:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573220051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1pgzP1sjoEP3vwcv/m9Ktl+kNGJMEq2RHHceZLIUy0=; b=OsYWJGIGtEkoQ8VSR9TyxZhZNPYXC+9AV0mAbzYtCX7kmNYqFWt0dJ0E42S/X6vNOufa2A 2QbE5FKhjsWWW09yjDYqJt6LPovN76COL4wIif84tcY9TIkwBSVLzgqzq8TW/BcRVrPKPQ mm49h4G6qESUPeE6bUZ0/kkgwSJRV1g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-ESS0KT-RMkW2Kv-rplUTuQ-1; Fri, 08 Nov 2019 08:34:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39B47800C72; Fri, 8 Nov 2019 13:34:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-3.gru2.redhat.com [10.97.116.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26DA41001938; Fri, 8 Nov 2019 13:34:01 +0000 (UTC) Subject: Re: [PATCH v2 2/2] configure: Check bzip2 is available To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Laszlo Ersek , Thomas Huth , qemu-trivial@nongnu.org References: <20191108114531.21518-1-philmd@redhat.com> <20191108114531.21518-3-philmd@redhat.com> <20191108114847.GM182396@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <12864b59-a0ac-b2eb-d398-e57efde6fd7c@redhat.com> Date: Fri, 8 Nov 2019 11:33:59 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20191108114847.GM182396@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: ESS0KT-RMkW2Kv-rplUTuQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 13:34:16 -0000 On 11/8/19 9:48 AM, Daniel P. Berrang=C3=A9 wrote: > On Fri, Nov 08, 2019 at 12:45:31PM +0100, Philippe Mathieu-Daud=C3=A9 wro= te: >> The bzip2 tool is not included in default installations. >> On freshly installed systems, ./configure succeeds but 'make' >> might fail later: >> >> BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 >> /bin/sh: bzip2: command not found >> make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 >> make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd' >> make: *** Waiting for unfinished jobs.... >> >> Add a check in ./configure to warn the user if bzip2 is missing. >> >> Fixes: 536d2173b2b >> Reported-by: Thomas Huth >> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >> --- >> v2: use better English (Daniel) >> (Not taking Daniel Reviewed-by because logic changed) >> --- >> configure | 4 ++++ >> 1 file changed, 4 insertions(+) >> diff --git a/configure b/configure >> index 9b322284c3..2b419a8039 100755 >> --- a/configure >> +++ b/configure >> @@ -2147,6 +2147,7 @@ case " $target_list " in >> ;; >> esac >> =20 >> +# Some firmware binaries are compressed with bzip2 > Squash into previous patch Ditto. > >> for target in $target_list; do >> case "$target" in >> arm-softmmu | aarch64-softmmu | i386-softmmu | x86_64-softmmu) >> @@ -2154,6 +2155,9 @@ for target in $target_list; do >> ;; >> esac >> done >> +if test "$edk2_blobs" =3D "yes" && ! has bzip2; then >> + error_exit "The bzip2 program is required for building QEMU" >> +fi >> =20 >> feature_not_found() { >> feature=3D$1 > Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Wainer dos Santos Moschetta - Wainer > > > Regards, > Daniel