From: Joe Perches Date: Wed, 20 Oct 2010 15:59:23 +0000 Subject: Re: [lm-sensors] [PATCH] drivers/hwmon: Use pr_fmt and pr_ Message-Id: <1287590363.1813.148.camel@Joe-Laptop> List-Id: References: <1287530020.10409.594.camel@Joe-Laptop> <20101020094208.3136b9dd@endymion.delvare> In-Reply-To: <20101020094208.3136b9dd@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean Delvare Cc: Guenter Roeck , Hans de Goede , Alistair John Strachan , Henrik Rydberg , "Mark M. Hoffman" , Luca Tettamanti , Fenghua Yu , Juerg Haefliger , Eric Piel , Jim Cromie , Roger Lucas , lm-sensors@lm-sensors.org, LKML On Wed, 2010-10-20 at 09:42 +0200, Jean Delvare wrote: > It looks odd that every driver would have to set this. Shouldn't this > be the default set in ? http://lkml.org/lkml/2009/10/4/198 http://lkml.org/lkml/2009/10/5/215 I'd prefer something like that as well, and it is a long-term goal I have, but not yet, no. There are many files that use pr_ without pr_fmt. Those need to be sorted out first, perhaps by adding a new line to each of those files to "#define pr_fmt(fmt) fmt" KBUILD_MODNAME is always #defined by the make system. $ grep -rP --include=*.[ch] -lw "pr_(info|warn|warning|notice|debug|dbg|vdbg|crit|alert|err|emerg|cont)" * | \ while read file ; do \ grep -lwq pr_fmt $file ; \ echo "$?:$file"; \ done | \ cut -f1 -d":" | sort | uniq -c 335 0 1532 1 Exit status 0 means a match for pr_fmt. So there are ~1900 files that use pr_ in the kernel tree, only 335 have pr_fmt. This search does have some false negatives because some files use an #include that does a #define pr_fmt. Anyway, I'd like to sort it out eventually. For now, I just add the #define pr_fmt, with a long term goal of removing them all and using a different mechanism to remove the duplicated prefix string altogether from the formats and save some text. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors