From: Joe Perches Date: Wed, 20 Oct 2010 16:54:20 +0000 Subject: Re: [lm-sensors] [PATCH] drivers/hwmon: Use pr_fmt and pr_ Message-Id: <1287593660.1813.198.camel@Joe-Laptop> List-Id: References: <1287530020.10409.594.camel@Joe-Laptop> <20101020094208.3136b9dd@endymion.delvare> <1287590363.1813.148.camel@Joe-Laptop> <20101020164929.GB22572@ericsson.com> In-Reply-To: <20101020164929.GB22572@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: Jean Delvare , Hans de Goede , Alistair John Strachan , Henrik Rydberg , "Mark M. Hoffman" , Luca Tettamanti , Fenghua Yu , Juerg Haefliger , Eric Piel , Jim Cromie , Roger Lucas , "lm-sensors@lm-sensors.org" , LKML On Wed, 2010-10-20 at 09:49 -0700, Guenter Roeck wrote: > On Wed, Oct 20, 2010 at 11:59:23AM -0400, > Joe Perches wrote: > [ ... ] > > Anyway, I'd like to sort it out eventually. > > For now, I just add the #define pr_fmt, with > > a long term goal of removing them all and using > > a different mechanism to remove the duplicated > > prefix string altogether from the formats and > > save some text. > I don't mind individual pr_fmt defines as long as they are used. > However, that is not the case in many of the patches. > Just adding a pr_fmt define to a file without using it doesn't make sense to me. kernel.h has the equivalent of: #define pr_(fmt, arg...) printk(KERN_ pr_fmt(fmt), ##arg) so the added "#define pr_fmt(fmt)..."s are used wherever pr_ is done. _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors