From: Ian Campbell Subject: Re: [Xen-devel] Re: [PATCH] xen: correct size of level2_kernel_pgt Date: Fri, 29 Oct 2010 18:55:33 +0100 Message-ID: <1288374933.8069.63.camel@localhost.localdomain> References: <1288367779-24001-1-git-send-email-ian.campbell@citrix.com> <4CCB02DC.1010307@goop.org> <1288373855.8069.27.camel@localhost.localdomain> <4CCB0836.3040200@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4CCB0836.3040200@goop.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" List-Id: xen-devel@lists.xenproject.org On Fri, 2010-10-29 at 18:45 +0100, Jeremy Fitzhardinge wrote: > On 10/29/2010 10:37 AM, Ian Campbell wrote: > > On Fri, 2010-10-29 at 18:22 +0100, Jeremy Fitzhardinge wrote: > >> On 10/29/2010 08:56 AM, Ian Campbell wrote: > >>> sizeof(pmd_t *) is 4 bytes on PAE leading to an allocation of only > >>> 2048 bytes. The correct size is sizeof(pmd_t) giving us a full page > >>> allocation. > >>> > >>> Signed-off-by: Ian Campbell > >>> Cc: Jeremy Fitzhardinge > >>> --- > >>> > >>> Applies to mainline since 2.6.36 and to xen.git 2.6.32 based trees > >> This is just for 2.6.37? > > 2.6.36.stable too, I think. I added stable@kernel.org to my patch header > > but didn't "guilt refresh" so it didn't show up here. > > The extend_brk() stuff was all merged this merge window. I checked out > .36 to confirm, and there's nothing there for your patch to apply to... Ah, I was suffering the classic confusion regarding a branch from before a release getting merged after. Thanks! Ian.