From: yangsheng Subject: [PATCH] jbd2_stats_proc_init wrong place. Date: Fri, 12 Nov 2010 03:43:16 +0800 Message-ID: <1289504596-26125-1-git-send-email-sheng.yang@oracle.com> Cc: yangsheng To: linux-fsdevel@vger.kernel.org Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:37783 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754152Ab0KKTop (ORCPT ); Thu, 11 Nov 2010 14:44:45 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oABJifnV029720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Nov 2010 19:44:43 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oABCDf86026478 for ; Thu, 11 Nov 2010 19:44:41 GMT Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The jbd2_stats_proc_init() was placed on wrong location in jbd2_journal_init_dev(). This may cause /proc/fs/jdb2//* cannot be created when using external journal device. --- fs/jbd2/journal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 13b0a92..2441bb1 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -899,7 +899,6 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev, /* journal descriptor can store up to n blocks -bzzz */ journal->j_blocksize = blocksize; - jbd2_stats_proc_init(journal); n = journal->j_blocksize / sizeof(journal_block_tag_t); journal->j_wbufsize = n; journal->j_wbuf = kmalloc(n * sizeof(struct buffer_head*), GFP_KERNEL); @@ -916,6 +915,7 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev, p = journal->j_devname; while ((p = strchr(p, '/'))) *p = '!'; + jbd2_stats_proc_init(journal); bh = __getblk(journal->j_dev, start, journal->j_blocksize); if (!bh) { -- 1.7.2.3