From: "Nicholas A. Bellinger" Subject: Re: [PATCH 02/11] libata: Convert to host_lock less w/ interrupts disabled internally Date: Thu, 11 Nov 2010 20:54:32 -0800 Message-ID: <1289537672.2867.203.camel@haakon2.linux-iscsi.org> References: <1289520817-16458-1-git-send-email-nab@linux-iscsi.org> <4CDCB8C1.6000303@garzik.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linux-iscsi.org ([67.23.28.174]:59141 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753702Ab0KLE7q (ORCPT ); Thu, 11 Nov 2010 23:59:46 -0500 In-Reply-To: <4CDCB8C1.6000303@garzik.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jeff Garzik Cc: linux-scsi , James Bottomley , Christoph Hellwig , Mike Christie , Ravi Anand , Andrew Vasquez , Joe Eykholt , James Smart , Vasu Dev , Tim Chen , Andi Kleen , Tejun Heo , Mike Anderson , MPTFusionLinux On Thu, 2010-11-11 at 22:47 -0500, Jeff Garzik wrote: > On 11/11/2010 07:13 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch changes ata_scsi_queuecmd_lck() to a host lock less > > ata_scsi_queuecmd() that will disable interrupts internally using > > ap->lock and drops the now legacy host_lock unlock. > > > > Signed-off-by: Nicholas A. Bellinger > > --- > > drivers/ata/libata-scsi.c | 14 ++++---------- > > 1 files changed, 4 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > > index a007c36..9614758 100644 > > --- a/drivers/ata/libata-scsi.c > > +++ b/drivers/ata/libata-scsi.c > > @@ -3173,25 +3173,22 @@ static inline int __ata_scsi_queuecmd(struct scsi_cmnd *scmd, > > * SCSI commands. This creates the overall effect of > > * ATA and ATAPI devices appearing as SCSI devices. > > * > > - * LOCKING: > > - * Releases scsi-layer-held lock, and obtains host lock. > > - * > > The code appears correct but the comment removal is not. > > Locking has not disappeared, and the ATA host lock continues to be obtained. > > My apologies for not reading this comment throughly.. Reinstating in lio-core-2.6.git/lock_less-LLDs-for-38 Thank you! --nab