From: Dan Rosenberg Date: Fri, 12 Nov 2010 15:11:51 +0000 Subject: Re: [PATCH 2/10] Fix leaking of kernel heap addresses in net/ Message-Id: <1289574711.3090.285.camel@Dan> List-Id: References: <1289524019.5167.66.camel@dan> <1289574562.2247.1.camel@achroite.uk.solarflarecom.com> In-Reply-To: <1289574562.2247.1.camel@achroite.uk.solarflarecom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ben Hutchings Cc: "David S. Miller" , Oliver Hartkopp , Alexey Kuznetsov , Urs Thuermann , Hideaki YOSHIFUJI , Patrick McHardy , James Morris , Remi Denis-Courmont , "Pekka Savola (ipv6)" , Sridhar Samudrala , Vlad Yasevich , Tejun Heo , Eric Dumazet , Li Zefan , Joe Perches , Stephen Hemminger , Jamal Hadi Salim , "Eric W. Biederman" , Alexey Dobriyan , Jiri Pirko , Johannes Berg , Daniel Lezcano , Pavel > On Thu, 2010-11-11 at 20:06 -0500, Dan Rosenberg wrote: > > diff --git a/net/can/bcm.c b/net/can/bcm.c > > index 08ffe9e..5960ad7 100644 > > --- a/net/can/bcm.c > > +++ b/net/can/bcm.c > [...] > > + seq_printf(m, ">>> socket %lu", sock_i_ino(sk)); > > Why decimal here... > > [...] > > + /* unique socket inode as filename */ > > + sprintf(bo->procname, "%lx", sock_i_ino(sk)); > > ...and hexadecimal here? > > Ben. > You're right, it should be consistent. I avoided decimal in the /proc filename because it may be too long - the next version will do the same for the seq_print output. -Dan