From: Peter Zijlstra Subject: Re: [PATCH 13/14] x86/ticketlock: add slowpath logic Date: Wed, 17 Nov 2010 13:21:43 +0100 Message-ID: <1289996503.2109.728.camel@laptop> References: <97ed99ae9160bdb6477284b333bd6708fb7a19cb.1289940821.git.jeremy.fitzhardinge@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <97ed99ae9160bdb6477284b333bd6708fb7a19cb.1289940821.git.jeremy.fitzhardinge@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Linux Kernel Mailing List , Nick Piggin , Mathieu Desnoyers , =?ISO-8859-1?Q?Am=E9rico?= Wang , Eric Dumazet , Jan Beulich , Avi Kivity , Xen-devel , "H. Peter Anvin" , Linux Virtualization , Srivatsa Vaddagiri , Jeremy Fitzhardinge List-Id: xen-devel@lists.xenproject.org On Tue, 2010-11-16 at 13:08 -0800, Jeremy Fitzhardinge wrote: > Maintain a flag in both LSBs of the ticket lock which indicates whether > anyone is in the lock slowpath and may need kicking when the current > holder unlocks. The flags are set when the first locker enters > the slowpath, and cleared when unlocking to an empty queue. So here you say you set both LSBs in order to keep head == tail working, but the code seems to suggest you only use the tail LSB. I think I see why using only one LSB is sufficient, but some consistency would be nice :-)