From: Thomas Weber Date: Thu, 25 Nov 2010 08:05:30 +0100 Subject: [U-Boot] [PATCHv2 3/3] powerpc: cmd_ecctest: Use return value of cmd_usage In-Reply-To: <1290668730-26595-1-git-send-email-weber@corscience.de> References: <1290668730-26595-1-git-send-email-weber@corscience.de> Message-ID: <1290668730-26595-4-git-send-email-weber@corscience.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Use the return value of cmd_usage instead of ignoring this and returning a 1. Signed-off-by: Thomas Weber --- arch/powerpc/cpu/ppc4xx/cmd_ecctest.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/cpu/ppc4xx/cmd_ecctest.c b/arch/powerpc/cpu/ppc4xx/cmd_ecctest.c index fd81b70..542ab69 100644 --- a/arch/powerpc/cpu/ppc4xx/cmd_ecctest.c +++ b/arch/powerpc/cpu/ppc4xx/cmd_ecctest.c @@ -190,15 +190,13 @@ static int do_ecctest(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) int error; if (argc < 3) { - cmd_usage(cmdtp); - return 1; + return cmd_usage(cmdtp); } ptr = (u32 *)simple_strtoul(argv[1], NULL, 16); error = simple_strtoul(argv[2], NULL, 16); if ((error < 1) || (error > 2)) { - cmd_usage(cmdtp); - return 1; + return cmd_usage(cmdtp); } printf("Using address %p for %d bit ECC error injection\n", -- 1.7.3.2