From: Haiying Wang Date: Thu, 25 Nov 2010 13:59:31 -0500 Subject: [U-Boot] [PATCH 09/24 V2] arch/powerpc/*/config.mk:makeCONFIG_SYS_LDSCRIPT settings work In-Reply-To: <20101125182823.21913D172C8@gemini.denx.de> References: <1290373420-3053-1-git-send-email-wd@denx.de> <1290700844-31427-10-git-send-email-wd@denx.de> <1290702018.2007.4.camel@haiying-laptop> <20101125171933.98B46D172C8@gemini.denx.de> <1290708988.2007.13.camel@haiying-laptop> <20101125182823.21913D172C8@gemini.denx.de> Message-ID: <1290711571.2007.20.camel@haiying-laptop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2010-11-25 at 11:28 -0700, Wolfgang Denk wrote: > Dear Haiying Wang, > > In message <1290708988.2007.13.camel@haiying-laptop> you wrote: > > > > > > u-boot-nand.lds is not in board/$(BOARDDIR) for 85xx at least, > it is > > > in > > > > $(SRCTREE)/$(CPUDIR)/ > > > > > > This is not correct - situation before applying my patches: > > > > > -> find * -name u-boot-nand.lds > > > arch/powerpc/cpu/mpc85xx/u-boot-nand.lds > > Oops, sorry. I missed that one, even though I was looking for it :-( > > > so your patch for arch/powerpc/config.mk will not get > u-boot-nand.lds > > for mpc85xx boards, only for the boards below. Then 85xx boards > still > > need to get the lds from board/$(BOARDIR)/config.mk. Is that what > you > > want? > > No, not really. But actually I was just cleaning up probems where ran > into them, not trying to perform a more general cleanup [*]. > > The situation is that the relevant 85xx boards appeare to have their > own config.mk files which explicitly set LDSCRIPT to the value they > need (which is indeed different from the default that gets set up ib > arch/powerpc/config.mk: > > arch/powerpc/config.mk: LDSCRIPT := > $(SRCTREE)/$(CONFIG_BOARDDIR)/u-boot-nand.lds > > board/freescale/mpc8536ds/config.mk: LDSCRIPT := > $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds > board/freescale/mpc8569mds/config.mk: LDSCRIPT := > $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds > board/freescale/p1_p2_rdb/config.mk: LDSCRIPT := > $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds > > So it seems my patches do not have any impact on the building of 85xx > systems. Or am I missing something? > No, your patch doesn't have impact on them. I just wonder if you wanted to apply your patch for 85xx board.:) Haiying