From: Joe Perches Date: Wed, 01 Dec 2010 06:27:55 -0800 Subject: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug In-Reply-To: References: <5febb0e1fba0ec2bb77f6ade8b251ba0edf4614c.1290988277.git.joe@perches.com> <20101129060732.5130.qmail@stuge.se> <4CF42C17.2070500@openwrt.org> <1291081185.16349.133.camel@Joe-Laptop> <4CF464D6.2020507@openwrt.org> <1291148375.18026.342.camel@Joe-Laptop> Message-ID: <1291213675.1845.12.camel@Joe-Laptop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote: > On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches wrote: > > Poor function naming is just that. > > It reduces readability and the uses are counter expectation. > The name is perfect, we use it to print anything, even non-debugging stuff. 'fraid not. ath/debug.h #ifdef CONFIG_ATH_DEBUG void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...) __attribute__ ((format (printf, 3, 4))); #else static inline void __attribute__ ((format (printf, 3, 4))) ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...) { } #endif /* CONFIG_ATH_DEBUG */