From: Gianni Tedesco Subject: Re: [PATCH 4 of 4] pyxl: Add _get_attribs() method to all classes Date: Fri, 10 Dec 2010 16:29:58 +0000 Message-ID: <1291998598.20366.157.camel@qabil.uk.xensource.com> References: <35dd6a11ce56488d01f9.1291902843@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <35dd6a11ce56488d01f9.1291902843@localhost6.localdomain6> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org On Thu, 2010-12-09 at 13:54 +0000, Gianni Tedesco wrote: > tools/python/genwrap.py | 18 ++++++++++++++++-- > tools/python/xen/lowlevel/xl/xl.c | 25 +++++++++++++++++++++++++ > 2 files changed, 41 insertions(+), 2 deletions(-) > > > # HG changeset patch > # User Gianni Tedesco > # Date 1291900689 0 > # Node ID 35dd6a11ce56488d01f9f1cb365e6035687390ca > # Parent 521af80c82bb6fc8e4403bbe2313b3a8b3c78841 > pyxl: Add _get_attribs() method to all classes > > This returns a dictionary of (attrib_name, value) tuples corresponding to all > fields of the libxl data-type that is being wrapped. This allows for creation > of super-classes of those types after they have been returned from libxl. I don't think this is strictly necessary now as it can be implemented in python code. Ian if you do apply these, you should hold off on this one. Gianni