Return-Path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:47092 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712Ab0LKXk7 (ORCPT ); Sat, 11 Dec 2010 18:40:59 -0500 Subject: Re: Change-Id's From: Daniel Walker In-Reply-To: References: <1292089193.4234.440.camel@m0nster> Content-Type: text/plain; charset="UTF-8" Date: Sat, 11 Dec 2010 15:40:58 -0800 Message-ID: <1292110858.4234.806.camel@m0nster> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, 2010-12-11 at 14:23 -0800, Linus Torvalds wrote: > On Dec 11, 2010 7:45 AM, "Daniel Walker" > wrote: > > > > How do people feel about Change-Id's at the end of commit messages? > > In general, I think the rule should be that tags are ok as long as > they are useful for EVERYBODY. if it's some internal company tag, > expect people to complain. If it doesn't have meaning to others, why > should it be in the public tree? Ok .. I couldn't agree with you more. > If you have some internal tracking thing, just associate the commit > ids (or " patch ids") with your internal tracker - don't make anybody > else have to look at crud that gas no meaning to them. > > (Sent from my phone so this probably has HTML crud and gets bounced > from the mailing lists) Hopefully my reply doesn't get bounced .. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.