From: Namhyung Kim Subject: [PATCH 3/3] compat: copy missing fields in compat_statfs64 to user Date: Mon, 27 Dec 2010 01:41:54 +0900 Message-ID: <1293381714-5264-3-git-send-email-namhyung@gmail.com> References: <1293381714-5264-1-git-send-email-namhyung@gmail.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig To: Alexander Viro Return-path: In-Reply-To: <1293381714-5264-1-git-send-email-namhyung@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org f_flags and f_spare fields were not copied to userspace when compat_sys_[f]statfs64 called. Signed-off-by: Namhyung Kim Cc: Christoph Hellwig --- It seems struct compat_statfs lacks the f_flags field in it but I'm not sure whether it is intended or not. Is it useful if I make a patch for it too? fs/compat.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/compat.c b/fs/compat.c index 037df434b038..2524511518e7 100644 --- a/fs/compat.c +++ b/fs/compat.c @@ -320,7 +320,9 @@ static int put_compat_statfs64(struct compat_statfs64 __user *ubuf, struct kstat __put_user(kbuf->f_namelen, &ubuf->f_namelen) || __put_user(kbuf->f_fsid.val[0], &ubuf->f_fsid.val[0]) || __put_user(kbuf->f_fsid.val[1], &ubuf->f_fsid.val[1]) || - __put_user(kbuf->f_frsize, &ubuf->f_frsize)) + __put_user(kbuf->f_frsize, &ubuf->f_frsize) || + __put_user(kbuf->f_flags, &ubuf->f_flags) || + __clear_user(ubuf->f_spare, sizeof(ubuf->f_spare))) return -EFAULT; return 0; } -- 1.7.3.4.600.g982838b0