From: York Sun Date: Mon, 10 Jan 2011 10:39:31 -0800 Subject: [U-Boot] [PATCH v2 2/9] make the hwconfig buffer deeper In-Reply-To: <6E3A9F82-EA2B-4B0B-BF4B-4323D6EFB9F4@kernel.crashing.org> References: <1292630381-23022-1-git-send-email-yorksun@freescale.com> <1292630381-23022-2-git-send-email-yorksun@freescale.com> <20101218222535.58FF31524E8@gemini.denx.de> <1294085287.24386.52.camel@oslab-l1> <20110103211125.710E5CEF7A6@gemini.denx.de> <1294089991.24386.58.camel@oslab-l1> <20110103214745.CCE33CEF94F@gemini.denx.de> <740DF509-6661-4611-BE1B-BBB629012697@kernel.crashing.org> <1294418957.8466.8.camel@oslab-l1> <20110107175217.2D3E42FC@gemini.denx.de> <6E3A9F82-EA2B-4B0B-BF4B-4323D6EFB9F4@kernel.crashing.org> Message-ID: <1294684771.3872.74.camel@oslab-l1> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 2011-01-09 at 15:00 -0600, Kumar Gala wrote: > On Jan 7, 2011, at 5:23 PM, Kumar Gala wrote: > > > > > On Jan 7, 2011, at 11:52 AM, Wolfgang Denk wrote: > > > >> Dear York Sun, > >> > >> In message <1294418957.8466.8.camel@oslab-l1> you wrote: > >>> > >>> fsl_ddr:ctlr_intlv=cacheline,bank_intlv=cs0_cs1_cs2_cs3,ecc=off,addr_hash=false > >>> > >>> With the buffer size 128, the sub function gets > >>> "ctlr_intlv=cacheline,bank_intlv=cs0_". It is not because the buffer is > >>> not enough, but the stack has been trashed. I have debug log if you need > >>> it. > >> > >> This is yet another problem, then. > > > > So I figured the problem out and need to rework the hwconfig API to fix it. > > > > We need some new versions of the APIs that take a buffer for use early before boot. > > I've posted: > > http://patchwork.ozlabs.org/patch/78045/ > http://patchwork.ozlabs.org/patch/78046/ > > Which should resolve the hwconfig issue and not require the patch to bump the size up. I have confirmed your patches. I will drop this patch and resubmit the rest. York