From: Gianni Tedesco Subject: Re: [PATCH 0 of 4] Python libxl binding updates Date: Tue, 11 Jan 2011 16:29:36 +0000 Message-ID: <1294763376.12018.146.camel@qabil.uk.xensource.com> References: <1294417533.12018.71.camel@qabil.uk.xensource.com> <19756.33633.213109.787338@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19756.33633.213109.787338@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Ian, Campbell , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Tue, 2011-01-11 at 16:20 +0000, Ian Jackson wrote: > Gianni Tedesco writes ("Re: [Xen-devel] [PATCH 0 of 4] Python libxl binding updates"): > > Do you think it would be possible to get a freeze exception so that I > > can re-submit this next week? It provides new features but only to the > > xl python bindings which are unused and unusable in their current state > > anyway. > > I think this is fine but we will look very closely at changes to > common code, specifically changes to the IDL and IDL compiler, for > which I'll manually verify that the generated code is unchanged. > > Can you please structure your changes to group together all the > changes to the IDL compiler ? Each incremental change to the generic IDL system is in lock-step with the changes to python binding because the python wrapper generator imports libxltypes.py from tools/libxl/ so a mis-match between them would cause build failures. Perhaps it is easier if I point out the patches which make these changes: [PATCH 08 of 10] xl: support array types in IDL - the main functional change [PATCH 09 of 10] xl: Implement enum types in IDL - trivial [PATCH 10 of 10] pyxl: Export libxl_domain_create_new() to python binding - actually uses the code implemented above by adding a new type to libxl.idl without this patch, the output doesn't change at all. Gianni