Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OA6UE-0003FT-IF for qemu-devel@nongnu.org; Thu, 06 May 2010 15:11:54 -0400 Received: from [140.186.70.92] (port=41540 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OA6UD-0003Co-2c for qemu-devel@nongnu.org; Thu, 06 May 2010 15:11:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OA6UC-00078X-23 for qemu-devel@nongnu.org; Thu, 06 May 2010 15:11:52 -0400 Received: from mail.gmx.net ([213.165.64.20]:55772) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OA6U9-000784-CO for qemu-devel@nongnu.org; Thu, 06 May 2010 15:11:52 -0400 Message-ID: <1296B50E61914D0290D02B8FBDDC5494@FSCPC> From: "Sebastian Herbszt" References: <4BDAD1A3.1040906@loongson.cn><62A72125-4FCF-4B72-82E5-24840460C3D2@suse.de><4BDD7596.6080207@loongson.cn><2FC4BB04CF31478F952129939300295C@FSCPC><4BDF7358.8050101@loongson.cn><5C35C8A4235E4017B4A83B54858C464E@FSCPC> <20100505193716.GA5982@zubnet.me.uk> In-Reply-To: <20100505193716.GA5982@zubnet.me.uk> Date: Thu, 6 May 2010 21:10:18 +0200 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Re: [RFC] [PATCH] add ahci support into qemu List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stuart Brady , qemu-devel@nongnu.org Stuart Brady wrote: > On Tue, May 04, 2010 at 10:51:37PM +0200, Sebastian Herbszt wrote: >> >diff --git a/hw/pci_ids.h b/hw/pci_ids.h >> >index fe7a121..4d4de93 100644 >> >--- a/hw/pci_ids.h >> >+++ b/hw/pci_ids.h >> >@@ -97,3 +97,4 @@ >> >#define PCI_DEVICE_ID_INTEL_82371AB 0x7111 >> >#define PCI_DEVICE_ID_INTEL_82371AB_2 0x7112 >> >#define PCI_DEVICE_ID_INTEL_82371AB_3 0x7113 >> >+#define PCI_DEVICE_ID_INTEL_ICH6R_AHCI 0x2652 >> >> The list is sorted by vendor and device id. This entry should go >> after "PCI_DEVICE_ID_INTEL_ESB_9". The naming scheme seems >> to be VENDOR_DEVICE_FUNCTION, so i suggest something like >> PCI_DEVICE_ID_INTEL_ICH6R_2 or PCI_DEVICE_ID_INTEL_82801FR_2. > > Linux seems to have called this PCI_DEVICE_ID_INTEL_ICH6_4 at one point. > > So this should be function 4, no? Well, i am not sure if the last part is the function number. pci_ids.h from the linux kernel got this: #define PCI_DEVICE_ID_INTEL_ICH6_0 0x2640 #define PCI_DEVICE_ID_INTEL_ICH6_1 0x2641 #define PCI_DEVICE_ID_INTEL_ICH6_2 0x2642 #define PCI_DEVICE_ID_INTEL_ICH6_16 0x266a #define PCI_DEVICE_ID_INTEL_ICH6_17 0x266d #define PCI_DEVICE_ID_INTEL_ICH6_18 0x266e #define PCI_DEVICE_ID_INTEL_ICH6_19 0x266f According to the Intel spec the SATA controller is D31:F2. So we got device 31 and function 2. The IDE controller is D31:F1, but above it's ICH6_19. Sebastian > Cheers, > -- > Stuart Brady > > >