From: Liam Girdwood Subject: Re: [PATCH] ASoC: codecs: wm8753: Fix DAI mode switching Date: Mon, 07 Feb 2011 19:10:25 +0000 Message-ID: <1297105825.3331.353.camel@odin> References: <1296983051-3105-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1296983051-3105-1-git-send-email-lars@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org To: Lars-Peter Clausen Cc: Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sun, 2011-02-06 at 10:04 +0100, Lars-Peter Clausen wrote: > The wm8753 codec supports switching between different DAI modes. > The current drivers tries to implement this by changing the DAI driver at > runtime. But to properly work this would require support from the ASoC core. > > So this patch takes a different approch on how the DAI mode switching is > implemented. > > The only difference, from a driver point of view, between the different DAI modes > is how to program the DAI format to the hardware. So what this patch is, it > stores the current format for each DAI in the drivers private struct and when > the DAI mode is changed the format gets simply reprogrammed according to the > new DAI mode. > > Futhermore this patch restricts the changing of the DAI format to when the > codec is inactive. > > Signed-off-by: Lars-Peter Clausen Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk